Skip to content

[WIP] Fix build error related to Example_C++20 target#5

Merged
virgil382 merged 1 commit intomasterfrom
copilot/fix-build-error-example-cpp20
Oct 8, 2025
Merged

[WIP] Fix build error related to Example_C++20 target#5
virgil382 merged 1 commit intomasterfrom
copilot/fix-build-error-example-cpp20

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Oct 8, 2025

Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.

Original prompt

This section details on the original issue you should resolve

<issue_title>Build fail regarding Example_C++20 target</issue_title>
<issue_description>There is a error when trying to build entire solution in Visual Studio.

...\JSLikePromise\Examples_C++20\example04.hpp(20,26): error C3688: invalid literal suffix 'ms'; literal operator or literal operator template 'operator ""ms' not found

Because the header <chrono> is not included explicitly.

diff --git a/Examples_C++20/example04.hpp b/Examples_C++20/example04.hpp
index 429c2b2..daa1d35 100644
--- a/Examples_C++20/example04.hpp
+++ b/Examples_C++20/example04.hpp
@@ -1,3 +1,5 @@
+#include <chrono>
+
 shared_ptr<PromiseState<int>> example04_promiseState;
 
 Promise<int> ex04_resolveAfter1Sec() {

(Or include the header from exmaples.cpp beforehand, if simplicity is important here. :D)

Not a big problem sine that is an error for helper target.
But it will be good to fix it so user won't need to investigate this when trying to pull and build the project. :D</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #3

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@virgil382 virgil382 marked this pull request as ready for review October 8, 2025 19:12
@virgil382 virgil382 merged commit 4a2cbfe into master Oct 8, 2025
1 check failed
Copilot AI requested a review from virgil382 October 8, 2025 19:13
@virgil382 virgil382 deleted the copilot/fix-build-error-example-cpp20 branch October 8, 2025 19:13
@virgil382 virgil382 restored the copilot/fix-build-error-example-cpp20 branch October 8, 2025 19:13
virgil382 added a commit that referenced this pull request Oct 8, 2025
This reverts commit 4a2cbfe.
@virgil382 virgil382 deleted the copilot/fix-build-error-example-cpp20 branch October 8, 2025 23:27
virgil382 added a commit that referenced this pull request Oct 8, 2025
This reverts commit 4a2cbfe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build fail regarding Example_C++20 target

2 participants