Test against multiple versions of Ruby and Rails

.github/workflows/tests.yml

@@ -2,26 +2,56 @@ name: Tests
 
 on:
   push:
-    branches: [ main ]
+    branches: [main]
   pull_request:
-    branches: [ main ]
+    branches: [main]
 
 jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ruby-3.3.0
+          bundler-cache: true
+
+      - name: Lint code for consistent style
+        run: bin/rubocop -f github
+
   test:
+    runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version:
-          - "3.1"
-    runs-on: ubuntu-latest
+        ruby: ["3.1", "3.2", "3.3"]
+        gemfile:
+          - rails_6_1
+          - rails_7_0
+          - rails_7_1
+          - rails_7_2
+          - rails_main
+        exclude:
+          - ruby: "3.1"
+            gemfile: "rails_main"
+
+    env:
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
+      RAILS_ENV: test
 
     steps:
-      - uses: actions/checkout@v3
+      - name: Checkout code
+        uses: actions/checkout@v4
 
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: ${{ matrix.ruby-version }}
+          ruby-version: ${{ matrix.ruby }}
           bundler-cache: true
 
       - name: Run tests
-        run: bin/rails test
+        run: |
+          bin/rails db:test:prepare
+          bin/rails test

.rubocop.yml

@@ -0,0 +1,4 @@
+# Omakase Ruby styling for Rails
+inherit_gem:
+  rubocop-rails-omakase: rubocop.yml
+# Your own specialized rules go here

Appraisals

@@ -0,0 +1,19 @@
+appraise "rails_6_1" do
+  gem "rails", "~> 6.1.0"
+end
+
+appraise "rails_7_0" do
+  gem "rails", "~> 7.0.0"
+end
+
+appraise "rails_7_1" do
+  gem "rails", "~> 7.1.0"
+end
+
+appraise "rails_7_2" do
+  gem "rails", "~> 7.2.0"
+end
+
+appraise "rails_main" do
+  gem "rails", github: "rails/rails", branch: "main"
+end

Gemfile

@@ -9,6 +9,7 @@ gem "puma"
 gem "sqlite3"
 
 gem "sprockets-rails"
+gem "rubocop-rails-omakase", require: false
 
 # Start debugger with binding.b [https://github.com/ruby/debug]
 # gem "debug", ">= 1.0.0"

Gemfile.lock

@@ -2,7 +2,7 @@ PATH
   remote: .
   specs:
     persisted_attributes (0.1.0)
-      rails (>= 7.1.3.4)
+      rails (>= 6.1.0)
 
 GEM
   remote: https://rubygems.org/
@@ -81,6 +81,11 @@ GEM
       minitest (>= 5.1)
       mutex_m
       tzinfo (~> 2.0)
+    appraisal (2.5.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    ast (2.4.2)
     base64 (0.2.0)
     bigdecimal (3.1.8)
     builder (3.3.0)
@@ -98,6 +103,8 @@ GEM
     irb (1.14.0)
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
+    json (2.7.2)
+    language_server-protocol (3.17.0.3)
     loofah (2.22.0)
       crass (~> 1.0.2)
       nokogiri (>= 1.12.0)
@@ -124,6 +131,10 @@ GEM
       racc (~> 1.4)
     nokogiri (1.16.7-x86_64-linux)
       racc (~> 1.4)
+    parallel (1.26.3)
+    parser (3.3.5.0)
+      ast (~> 2.4.1)
+      racc
     psych (5.1.2)
       stringio
     puma (6.4.2)
@@ -166,11 +177,42 @@ GEM
       rake (>= 12.2)
       thor (~> 1.0, >= 1.2.2)
       zeitwerk (~> 2.6)
+    rainbow (3.1.1)
     rake (13.2.1)
     rdoc (6.7.0)
       psych (>= 4.0.0)
+    regexp_parser (2.9.2)
     reline (0.5.9)
       io-console (~> 0.5)
+    rubocop (1.66.1)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
+      parallel (~> 1.10)
+      parser (>= 3.3.0.2)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 2.4, < 3.0)
+      rubocop-ast (>= 1.32.2, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.32.3)
+      parser (>= 3.3.1.0)
+    rubocop-minitest (0.36.0)
+      rubocop (>= 1.61, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
+    rubocop-performance (1.22.1)
+      rubocop (>= 1.48.1, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
+    rubocop-rails (2.26.2)
+      activesupport (>= 4.2.0)
+      rack (>= 1.1)
+      rubocop (>= 1.52.0, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
+    rubocop-rails-omakase (1.0.0)
+      rubocop
+      rubocop-minitest
+      rubocop-performance
+      rubocop-rails
+    ruby-progressbar (1.13.0)
     sprockets (4.2.1)
       concurrent-ruby (~> 1.0)
       rack (>= 2.2.4, < 4)
@@ -185,6 +227,7 @@ GEM
     timeout (0.4.1)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
+    unicode-display_width (2.6.0)
     webrick (1.8.1)
     websocket-driver (0.7.6)
       websocket-extensions (>= 0.1.0)
@@ -196,8 +239,10 @@ PLATFORMS
   x86_64-linux
 
 DEPENDENCIES
+  appraisal
   persisted_attributes!
   puma
+  rubocop-rails-omakase
   sprockets-rails
   sqlite3
 

app/models/persisted_attributes/attribute.rb

@@ -11,17 +11,17 @@ class Attribute < ApplicationRecord
     belongs_to :record, polymorphic: true
 
     validates :name, presence: true
-    validates :name, uniqueness: { scope: [:record_type, :record_id] }
+    validates :name, uniqueness: { scope: [ :record_type, :record_id ] }
 
     class << self
       def attribute_class_for_attribute_type(attribute_type)
         case attribute_type
         when :string
-          return "PersistedAttributes::Attribute::StringAttribute"
+          "PersistedAttributes::Attribute::StringAttribute"
         when :integer
-          return "PersistedAttributes::Attribute::IntegerAttribute"
+          "PersistedAttributes::Attribute::IntegerAttribute"
         when :boolean
-          return "PersistedAttributes::Attribute::BooleanAttribute"
+          "PersistedAttributes::Attribute::BooleanAttribute"
         end
       end
     end

bin/rubocop

@@ -0,0 +1,27 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'rubocop' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+
+bundle_binstub = File.expand_path("bundle", __dir__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300).include?("This file was generated by Bundler")
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("rubocop", "rubocop")

gemfiles/rails_6_1.gemfile

@@ -0,0 +1,11 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "puma"
+gem "sqlite3"
+gem "sprockets-rails"
+gem "rubocop-rails-omakase", require: false
+gem "rails", "~> 6.1.0"
+
+gemspec path: "../"