Merged
Conversation
virolea
force-pushed
the
new-domain-model-for-translations
branch
23 times, most recently
from
17aa90d to
26b4cf7
Compare
virolea
force-pushed
the
new-domain-model-for-translations
branch
from
a6990a3 to
7d42fef
Compare
virolea
force-pushed
the
new-domain-model-for-translations
branch
from
7d42fef to
fcb7c4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Breaking change
In this PR we overhaul the data model to account for future development of #10 and #6.
It's been decided to remove the
TranslationKeyobject in favour of a genericTextEntryone.Everything now is a TextEntry, whether it's the text picked from the views in the default locale, to translated versions.
TextEntries are linked together through the translation model. The translation model now represent the translation from a given text entry to another, in a target locale. This made more sense, and will enable variations of the base untranslated texts.