Use newest enterprise-groovy version - #14
Conversation
virtualdogbert
left a comment
There was a problem hiding this comment.
I think that I need an example of how this will actually work, and why the change is necessary. This isn't to say what you're purposing isn't valid, I just want to understand, what this is and why you need it.
Also, the documentation would need to be updated to reflect the new configuration parameters allowedSuppressions and what those would do for the user.
I'm also thinking if/when I do let this in I'll probably bump the version, as this is new functionality and not just a bug fix...
|
I've just been converting a project to compilestatic using the plugin. There are a couple of methods, that require dynamic overload resolution at runtime, because if you specifiy fx. Object as the parameter type it will always resolve to the overload with an object parameter. Codenarc also complains, so a @SuppressWarnings('NoDef') is added. Unfortunately the plugin is either on or off, so there is no way to exclude this one method from the def required. In most places def is the devil's work, but here it is not. Fx: In reality I would expect suppressions to be respected anyway. |
|
I've added a commit with the doc changes, but I can't get this PR to update and I can't create a new PR with the new commit. How do you update the PR with a new commit? |
|
Hmm strange you should be able to update a PR by just pushing new commits to the branch that you are trying to get merged in the PR... but created a new PR will work too, just lose the context of the old PR... |
|
Issue: #15 |
This is related to virtualdogbert/enterprise-groovy#2