Added multilingual language incl dropdown support#428
Conversation
|
@dishas75 is attempting to deploy a commit to the CodeBlooded's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
hi @viru0909-dev i noticed that there are merge conflicts. Please let me know if i should resolve them from my side. |
|
@dishas75 Resolve conflicts with the |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
viru0909-dev
left a comment
There was a problem hiding this comment.
Hi @dishas75, thank you for the multilingual dropdown implementation. The concept is solid, and the i18next integration approach is on the right track.
However, I tested this PR locally, and the build fails with two errors that need to be fixed before this can be merged.
Error 1: Duplicate CSS key in Constitution.jsx line 649
There is a duplicate background property inside an inline style object.
Please remove the redundant entry and keep only one background property.
Error 2: Mismatched JSX tags in the Navbar component
The JSX structure in the Navbar has a tag mismatch. It opens with <div> but closes with </motion.header>, which is causing the entire build to fail.
Please audit the Navbar component and make sure all opening and closing tags are correctly paired.
Once these two issues are fixed and the build passes locally using:
npm run build
please rebase your branch with the latest main before requesting a re-review, as there are some recent changes to the dark/light mode system and Marathi translation keys that you will need to include.
Please let me know if you need any help resolving these.
|
@dishas75 Can you please rebase your branch with our latest changes? We have added dark/light mode, and Hindi/Marathi support is also already there now. There are also some frontend issues in your PR that need to be fixed before we can move forward. |
…ked working of all pages suvvessfully
|
yes @viru0909-dev , I'll look into this issue by rebasing my branch with the latest changes added |
|
as im getting constant irregularities and merge conflicts with rebasing the code, i need some time to fix this issue as the language part is distorted totally into incomplete code and its creating an issue @viru0909-dev |
|
@dishas75 You can see the current changes are breaking the UI component in the navbar.
And this is our latest deployed working UI:
Please rebase your code with the latest Please try to complete this by tonight, as I am not making any other UI changes until then. Otherwise, we may face merge conflicts again. |
|
Hey,i have updated my ui and ensured that there are no merge conflicts,pls recheck @viru0909-dev i have also remodified the marathi translation,so pls check that also. |
|
@dishas75 Good work! Everything looks good overall. Before I merge this, I want one small UI change in the navbar. Please make all navbar components align properly in a single linear row like the latest main UI. Currently, the language dropdown and some navbar elements look slightly misaligned compared to our latest design. Please match the navbar spacing/alignment with the latest deployed UI and then update the PR with a screenshot. Once done, I will merge it immediately. |






Pull Request
Description
Added a language selection dropdown to improve multilingual accessibility of the website
Closes #269
Type of change
Checklist: