Skip to content

Added multilingual language incl dropdown support#428

Open
dishas75 wants to merge 8 commits into
viru0909-dev:mainfrom
dishas75:translation-enhancement
Open

Added multilingual language incl dropdown support#428
dishas75 wants to merge 8 commits into
viru0909-dev:mainfrom
dishas75:translation-enhancement

Conversation

@dishas75
Copy link
Copy Markdown

@dishas75 dishas75 commented May 17, 2026

Pull Request

Description

Added a language selection dropdown to improve multilingual accessibility of the website
Closes #269

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [✅] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • [✅] My code follows the style guidelines of this project
  • [✅] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [✅] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [✅] New and existing unit tests pass locally with my changes
Screenshot 2026-05-17 155139 Screenshot 2026-05-17 155120 Screenshot 2026-05-17 155107

@dishas75 dishas75 requested a review from viru0909-dev as a code owner May 17, 2026 10:17
@vercel
Copy link
Copy Markdown

vercel Bot commented May 17, 2026

@dishas75 is attempting to deploy a commit to the CodeBlooded's projects Team on Vercel.

A member of the Team first needs to authorize it.

@dishas75
Copy link
Copy Markdown
Author

hi @viru0909-dev i noticed that there are merge conflicts. Please let me know if i should resolve them from my side.

@viru0909-dev
Copy link
Copy Markdown
Owner

@dishas75 Resolve conflicts with the main branch and also add the output screenshot.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nyaysetu Error Error May 19, 2026 7:57am

Copy link
Copy Markdown
Owner

@viru0909-dev viru0909-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dishas75, thank you for the multilingual dropdown implementation. The concept is solid, and the i18next integration approach is on the right track.

However, I tested this PR locally, and the build fails with two errors that need to be fixed before this can be merged.


Error 1: Duplicate CSS key in Constitution.jsx line 649

There is a duplicate background property inside an inline style object.

Please remove the redundant entry and keep only one background property.


Error 2: Mismatched JSX tags in the Navbar component

The JSX structure in the Navbar has a tag mismatch. It opens with <div> but closes with </motion.header>, which is causing the entire build to fail.

Please audit the Navbar component and make sure all opening and closing tags are correctly paired.


Once these two issues are fixed and the build passes locally using:

npm run build

please rebase your branch with the latest main before requesting a re-review, as there are some recent changes to the dark/light mode system and Marathi translation keys that you will need to include.

Please let me know if you need any help resolving these.

@viru0909-dev
Copy link
Copy Markdown
Owner

@dishas75 Can you please rebase your branch with our latest changes?

We have added dark/light mode, and Hindi/Marathi support is also already there now. There are also some frontend issues in your PR that need to be fixed before we can move forward.

@dishas75
Copy link
Copy Markdown
Author

yes @viru0909-dev , I'll look into this issue by rebasing my branch with the latest changes added

@dishas75
Copy link
Copy Markdown
Author

as im getting constant irregularities and merge conflicts with rebasing the code, i need some time to fix this issue as the language part is distorted totally into incomplete code and its creating an issue @viru0909-dev

@viru0909-dev
Copy link
Copy Markdown
Owner

@dishas75 You can see the current changes are breaking the UI component in the navbar.

image

And this is our latest deployed working UI:

image

Please rebase your code with the latest main and fix this small issue. Once done, I will merge it immediately.

Please try to complete this by tonight, as I am not making any other UI changes until then. Otherwise, we may face merge conflicts again.

@dishas75
Copy link
Copy Markdown
Author

Hey,i have updated my ui and ensured that there are no merge conflicts,pls recheck @viru0909-dev i have also remodified the marathi translation,so pls check that also.
Screenshot 2026-05-18 114158
Screenshot 2026-05-18 114000
Screenshot 2026-05-18 113944
Screenshot 2026-05-18 113927

@viru0909-dev
Copy link
Copy Markdown
Owner

@dishas75 Good work! Everything looks good overall.

Before I merge this, I want one small UI change in the navbar. Please make all navbar components align properly in a single linear row like the latest main UI.

Currently, the language dropdown and some navbar elements look slightly misaligned compared to our latest design.

Please match the navbar spacing/alignment with the latest deployed UI and then update the PR with a screenshot.

Once done, I will merge it immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT]: Multilingual Accessibility Support for South Indian Languages

2 participants