Fix CSS scale handling by passing through mjolnir.js event data#558
Open
rjwats wants to merge 2 commits intovisgl:masterfrom
Open
Fix CSS scale handling by passing through mjolnir.js event data#558rjwats wants to merge 2 commits intovisgl:masterfrom
rjwats wants to merge 2 commits intovisgl:masterfrom
Conversation
Contributor
Author
|
I've added a unit test for the abstract class which this PR updates. It's so heavily integrated with deck.gl and mjolnir.js that there's a lot of mocking needed to exercise the code.. maybe there's a better way to test this? |
Contributor
Author
|
To locally test this you can add this div around the DeckGL element in advanced editor example: <div
style={{
transform: 'scaleX(1.2) scaleY(0.8)',
transformOrigin: 'center',
width: '100%',
height: '100%'
}}
>
<DeckGL>.... </DeckGL>
</div>Behavior before the fix: before.mp4Behavior after the fix: after.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect screen coordinate calculation in EditableLayer by using the offsetCenter provided by mjolnir.js gesture events, instead of recomputing coordinates from the DOM event (clientX/Y + canvas bounds).
I've also tightened up the types in
editable-layer.ts, there are a lot of events typed asanywhich this tries to address too.Some local manual testing done, no tests written yet - raising to get initial thoughts on this approach.