fix(context): prevent tiny-budget overflow - #12
Open
vibe-cy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the remaining context budget is smaller than the truncation suffix, pinned context blocks can still be truncated and kept. In that case, the resulting truncated block may exceed the available budget instead of being dropped.
Solution
Apply the same minimum remaining-budget guard used by candidate blocks to pinned blocks. If the remaining budget cannot fit both content and the truncation notice, the pinned block is dropped and recorded in the budget ledger with
final_cost=0.Changes
remaining <= len(TRUNCATION_SUFFIX).Testing
uv run pytest tests/test_context/test_budget_cost.py -quv run pytest tests/test_context -quv run ruff check leagent/context/budget.py tests/test_context/test_budget_cost.pyNotes for Reviewer
This keeps pinned block behavior aligned with the existing candidate block path. Pinned blocks are still preserved whenever the remaining budget can fit a truncation notice plus at least one body character.