Skip to content

Fixed '<g> </g>' becoming '<g></g>' and made beautification idempotent#7

Open
alubbe wants to merge 4 commits intovkiryukhin:masterfrom
alubbe:master
Open

Fixed '<g> </g>' becoming '<g></g>' and made beautification idempotent#7
alubbe wants to merge 4 commits intovkiryukhin:masterfrom
alubbe:master

Conversation

@alubbe
Copy link

@alubbe alubbe commented Jan 8, 2015

Both fixes come with tests

Idempotence means that applying beautification more than once does not change the result. Before, running it twice on the test input yielded this

  <d>
    <soapenv:Envelope

      xmlns:soapenv="http://xxx"

      xmlns:xsd="http://yyy"

      xmlns:xsi="http://zzz">
    </soapenv>
  </d>

@alubbe
Copy link
Author

alubbe commented Dec 31, 2016

hey @vkiryukhin is this package still maintained / is there any interest in seeing this PR merged? If you prefer, I can clean up the diff by extracting the whitespace commits into a separate PR. Happy 2017!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant