Conversation
- Initial Cobra setup - Started validation / testing
- enhanced gitignore with idea exclusions
- Travis / codeclimate setup
- Building Validation logic
- small cleanup
- small cleanup
- finalising concat cmd
- added multi OS build to travis (linux and osx as for now)
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| if util.AskConfirmation(fmt.Sprintf("%d files found eligble for concatination. Would you like to procceed?", len(files))) { | ||
| var outputFile, errOutputFileCreate = os.Create(absOutput) | ||
|
|
||
| if errOutputFileCreate != nil { |
There was a problem hiding this comment.
Avoid deeply nested control flow statements.
| "strings" | ||
| ) | ||
|
|
||
| func AskConfirmation(message string) bool { |
There was a problem hiding this comment.
exported function AskConfirmation should have comment or be unexported
| redColor = color.New(color.FgRed) | ||
| ) | ||
|
|
||
| func RunConcatCmd(sources string, output string) *execution.Result { |
There was a problem hiding this comment.
Function RunConcatCmd has a Cognitive Complexity of 38 (exceeds 20 allowed). Consider refactoring.
| @@ -0,0 +1,138 @@ | |||
| /* | |||
There was a problem hiding this comment.
package comment should be of the form "Package cmd ..."
| redColor = color.New(color.FgRed) | ||
| ) | ||
|
|
||
| func RunConcatCmd(sources string, output string) *execution.Result { |
There was a problem hiding this comment.
exported function RunConcatCmd should have comment or be unexported
- build fix
| redColor = color.New(color.FgRed) | ||
| ) | ||
|
|
||
| func RunConcatCmd(sources string, output string) *execution.Result { |
There was a problem hiding this comment.
Function RunConcatCmd has 52 lines of code (exceeds 50 allowed). Consider refactoring.
| return executionResult | ||
| } | ||
|
|
||
| func Validate(sourcesPath []string, output string) *validation.Result { |
There was a problem hiding this comment.
exported function Validate should have comment or be unexported
| @@ -0,0 +1,91 @@ | |||
| /* | |||
There was a problem hiding this comment.
package comment should be of the form "Package cmd ..."
| "github.com/vkrava4/k-toolkit/validation" | ||
| ) | ||
|
|
||
| type Result struct { |
There was a problem hiding this comment.
exported type Result should have comment or be unexported
| redColor = color.New(color.FgRed) | ||
| ) | ||
|
|
||
| func (v *Result) PrintPretty() { |
There was a problem hiding this comment.
exported method Result.PrintPretty should have comment or be unexported
|
Code Climate has analyzed commit e2286d5 and detected 24 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 22.3% (80% is the threshold). This pull request will bring the total coverage in the repository to 22.3%. View more on Code Climate. |
1 participant
No description provided.