fix(dock): tabbed panel groups render a blank gap above their content#64
Merged
Conversation
Contributor
|
@MartenH You need to rebase/sync your branch with the current vlang/gui main branch, because your PR is still using the old Windows CI workflow with V_VERSION: 0.5.1 Thanks! |
A panel group with 2+ tabs rendered a large empty gap between the tab bar and the
panel content. The per-tab separator was `column(width: 1, sizing: fixed_fill)` — a
height-fill child inside the fit-height `dock_tab_bar` row, so the row expanded to
fill the group instead of fitting the tabs, pushing the content down. It only
showed with 2+ tabs (the separator is added between tabs), so single-tab groups
were fine.
Give the separator a definite height (fixed_fixed) so the tab bar fits its tabs
again; the divider is still drawn.
Repro: put two panels in one group, e.g.
dock_panel_group('g', ['a', 'b'], 'a')
and observe the blank band above the content; gone with this change.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1486506 to
85e2ecc
Compare
Contributor
Author
|
@GGRei Done |
dy-tea
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A dock panel group with 2+ tabs (e.g. created by dragging one panel onto another via the center/tabify drop zone) renders a large empty band between the tab bar and the panel content. Single-tab groups are fine, so it only appears once a group has more than one tab.
Cause
In
view_dock_layout.v, the per-tab separator is built as:That's a height-fill child placed inside the fit-height
dock_tab_barrow (sizing: fill_fit). A fill child in a fit container makes the row expand to fill the available group height instead of fitting the tabs, so the tab bar balloons and pushes the content down. The separator is only added between tabs, which is why the gap appears only with 2+ tabs.Fix
Give the separator a definite height (
fixed_fixed) instead offixed_fill, so the tab bar fits its tabs again. The divider is still drawn.Repro
Put two panels in one group:
Before: a blank band sits above the content. After: content sits directly under the tab bar.
Verified in a real ~25-panel dockable app: tabbing any two panels together now renders cleanly.