feat: add AgentSkill type and skills support to generate methods#125
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
feat: add AgentSkill type and skills support to generate methods#125devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
- Add AgentSkill class/interface with skillId, skillName, version fields - Add skills field to GenerationConfig, AgentExecutionConfig, AgentCreationConfig - Make domain optional in image/file generate when skills provided - Add validation requiring either domain or config.skills Co-Authored-By: dinesh@vlm.run <dinesh@vlm.run>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add AgentSkill type and skills support to generate methods
Summary
Adds support for skill-based requests as an alternative to domain-based requests, aligning the Node SDK with vlm-lab#1621.
Types (
types.ts):AgentSkillclass,AgentSkillParamsinterface, andAgentSkillInputunion type withskillId,skillName,version, andtypefieldsdomainmade optional inPredictionGenerateParamsskillsfield added toGenerationConfigParams,GenerationConfig,AgentExecutionConfigParams,AgentExecutionConfig,AgentCreationConfigParams,AgentCreationConfigtoJSON()methods serialize skills with snake_case keys for API compatibilityPredictions (
predictions.ts):ImagePredictions.generate()andFilePredictions.generate()now validate that eitherdomainorconfig.skillsis provideddomainis conditionally included in the request payload (omitted when undefined)_castResponseToSchemais only called whendomainis presentReview & Testing Checklist for Human
AgentSkillconstructor handles edge cases:Object.assign(this, params)can overwrite class defaults withundefinedif params explicitly contains{ type: undefined }or{ version: undefined }. Consider whether this needs a guard.skills: undefinedin request payload is acceptable: When no skills are provided,serializedSkillsisundefinedand gets sent asskills: undefinedinside the config object. Confirm the backend handles this (vs. omitting the key entirely).image.generate()anddocument.generate()withconfig.skillsinstead ofdomainand confirm the backend resolves the skill and returns a valid response.domainwithout skills should continue to work identically._castResponseToSchemaskip is intentional: When using skills without domain, schema casting is now skipped. Verify this is the desired behavior for skill-based responses.Notes
chat-completions.test.tsare unrelated.