Fixing dependecy conflict, add port argument and allign readme.md#2
Open
FunkyOz wants to merge 6 commits intovlorenzo:mainfrom
Open
Fixing dependecy conflict, add port argument and allign readme.md#2FunkyOz wants to merge 6 commits intovlorenzo:mainfrom
FunkyOz wants to merge 6 commits intovlorenzo:mainfrom
Conversation
…pygoogletranslation). Add port argument to main command.
…pygoogletranslation). Add port argument to main command.
…fix-dependecy-conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the goggle translations library cause the previous one had conflicts with openai library (see ssut/py-googletrans#400).
The solution explained in this issue does not work so I decide to migrate to pygoogletranslation, at the version 2.0.5 (instead of 2.0.6 cause is broken too). The apis of these libraries are the same so I changed only one line of the code. Now we're able to install requirement directly from requirements.txt without any workaround.
Additionally I make two other changes: