feat: improve SQL error messages with column context and did-you-mean hint#110
Merged
feat: improve SQL error messages with column context and did-you-mean hint#110
Conversation
… hint On SQL query errors (exit 3), print the available column names from PRAGMA table_info(t) and suggest the closest match when the missing identifier has Levenshtein distance ≤ 2 from an existing column. Also fix a double-free bug in csv.zig where manual cleanup before returning error.UnterminatedQuotedField clashed with errdefer blocks. Closes #81
--delimiter and --tsv only affect input parsing; they are orthogonal to the output format. Only --header (which also affects output) should be incompatible with --json.
3dc6ee6 to
c2e6f33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #81
PRAGMA table_info(t)and suggest the closest match when the missing identifier has edit distance ≤ 2 from an existing column name.--jsonincorrectly rejected when combined with--delimiter/--tsv(those flags only affect input parsing, not output format).csv.zigtriggered byerror.UnterminatedQuotedFieldwhen manual cleanup clashed witherrdeferblocks.New behaviour
Changes
src/main.zig—levenshteinDistance,getTableColumns,printSqlErrorContext,fatalSqlWithContext; all post-createTableSQL errors now usefatalSqlWithContext;--jsonincompatibility narrowed to--headeronlysrc/csv.zig— remove manual cleanup beforereturn error.UnterminatedQuotedField(was double-freeing memory already owned byerrdefer)build.zig— integration tests 26 (column list on SQL error), 27 (did-you-mean hint), 28 (CSV row number), 17b (--json+--delimiternow works)README.md— Exit Codes section updated with example output