🐛 Move VM Prometheus metrics into separate controller#1531
Draft
bryanv wants to merge 1 commit into
Draft
Conversation
Doing this in the primary VM controller has a few drawbacks: - this can be CPU consuming, slowing reconcile throughput - metrics were updated on every reconcile, even if nothing had changed, so it incurred a lot of allocations This doesn't address some of other issues here like high cardinality of the VM condition metrics but that is for later.
bryanv
force-pushed
the
bryanv/move-vm-metrics-to-separate-controller
branch
from
5a74b41 to
8ef7968
Compare
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Doing this in the primary VM controller has a few drawbacks:
This doesn't address some of other issues here like high cardinality of the VM condition metrics but that is for later.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: