Reconcile VMLocation when it's moved to different RP or folder and set appropriate conditions#1558
Open
anwithaun-1 wants to merge 16 commits into
Open
Reconcile VMLocation when it's moved to different RP or folder and set appropriate conditions#1558anwithaun-1 wants to merge 16 commits into
anwithaun-1 wants to merge 16 commits into
Conversation
github-actions
Bot
added
size/M
anwithaun-1
changed the title
anwithaun-1
changed the title
aakashchan
reviewed
Apr 22, 2026
aakashchan
reviewed
Apr 22, 2026
added 2 commits
April 22, 2026 18:50
bryanv
reviewed
Apr 24, 2026
hpannem
reviewed
Apr 27, 2026
anwithaun-1
commented
Apr 30, 2026
Contributor
Author
anwithaun-1
left a comment
anwithaun-1
left a comment
There was a problem hiding this comment.
Please take a look at the addressed comments.
Minimum allowed line rate is |
anwithaun-1
commented
May 11, 2026
Contributor
Author
anwithaun-1
left a comment
anwithaun-1
left a comment
There was a problem hiding this comment.
Resolved all the comments. pls review again.
bryanv
reviewed
May 11, 2026
| ctx, | ||
| vcClient.VimClient(), | ||
| nil, | ||
| []string{"resourcePool", |
Contributor
There was a problem hiding this comment.
When set, the default DefaultWatchedPropertyPaths() is no longer used so that will break the watcher functionality that we need.
Also, the VM managed object doesn't have a parent field. What that one trying to watch?
Contributor
Author
There was a problem hiding this comment.
@bryanv can I add these property in DefaultWatchedPropertyPaths() then?
| vmCtx.VM, | ||
| vmopv1.VirtualMachineConditionInAuthorizedLocation, | ||
| "LocationMismatch", | ||
| "VM is in an unauthorized Resource Pool. Move the VM back to the Resource Pool hierarchy for namespace '%s' to resume reconciliation.", |
Contributor
There was a problem hiding this comment.
NS can't have spaces in the name so I don't think quotes are needed
| vmCtx.VM.Namespace, | ||
| ) | ||
|
|
||
| return pkgerr.NoRequeueError{Message: fmt.Errorf( |
Contributor
There was a problem hiding this comment.
Can't this use Sprintf instead of calling Error() on a error that was just built?
Doesn't the context of where this is use include the VM name?
Contributor
Author
There was a problem hiding this comment.
We can use sprintf also in this case. I used Errorf as this has been used at many places with NoRequeue.
| if currentRPMoRef.Value == expectedRootRPMoID { | ||
| isValid = true | ||
| } else { | ||
| poolObj := object.NewResourcePool(vcClient.VimClient(), currentRPMoRef) |
Contributor
There was a problem hiding this comment.
We have some RP related helpers in vsphere/vcenter/resourcepool.go that this could be moved to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Problem:
Currently, the VM Operator does not set appropriate conditions or halt reconciliation when a VM is moved out of its designated resource pool or folder. This leads to two major issues:
Permission Creep: DevOps admin privileges are inadvertently extended to reconfigure VMs that have drifted into different inventory locations.
Lack of Visibility: There is no "stop-gap" or clear status indicator telling administrators that the VM is in an orphaned state, leading to unpredictable reconciliation behavior.
Solution:
State Conflict: Two instances of the same workload existing simultaneously in different locations.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
VMSVC-3539
VMSVC-3541
Are there any special notes for your reviewer:
Please add a release note if necessary: