🌱 Add VirtualMachineService condition for underlying Service Ready#1593
Open
bryanv wants to merge 1 commit into
Open
🌱 Add VirtualMachineService condition for underlying Service Ready#1593bryanv wants to merge 1 commit into
bryanv wants to merge 1 commit into
Conversation
bryanv
force-pushed
the
bryanv/add-virtualmachineservice-ready-condition
branch
2 times, most recently
from
82e22b2 to
42cd1f6
Compare
Reflect the underlying Service Ready condition in the VirtualMachineService conditions. Note that most of our Service LB providers do not set the Ready condition. So it that case we'll report that as Unknown in our condition.
bryanv
force-pushed
the
bryanv/add-virtualmachineservice-ready-condition
branch
from
42cd1f6 to
c1261ae
Compare
Minimum allowed line rate is |
| // Note that not all LoadBalancer providers set a Ready condition on the | ||
| // Service. When the condition is not present, this condition will have | ||
| // Status of Unknown with the Reason "ServiceReadyNotPresent". | ||
| ServiceReadyConditionType = "VirtualMachineServiceServiceReady" |
Contributor
There was a problem hiding this comment.
can we not do it with one Service?
|
|
||
| // Check for Ready condition in the underlying Service and reflect it on VirtualMachineService | ||
| if readyCond := getServiceReadyCondition(service); readyCond != nil { | ||
| switch readyCond.Status { |
Contributor
There was a problem hiding this comment.
why not have the getServiceReadyCondition construct and update the condition making this method shorter. the getServiceReadyCondition doesn't do much as is
faisalabujabal
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Reflect the underlying Service Ready condition on the VirtualMachineService conditions.
Note that most of our Service LB providers do not set the Ready condition. So it that case we'll report that as Unknown in our condition.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: