Instrument workspace/runtime startup with StartupTrace

[vogella]

Summary

Adds StartupTrace.begin/record spans around the key platform startup paths so local profiling builds can attribute startup cost to individual phases instead of estimating from code inspection.

Instrumented phases

• Workspace.open (total) with sub-spans for setExplicitWorkspaceEncoding, initializePreferenceLookupOrder, inner startup, notification-manager restart, and crash-recovery refresh.
• Workspace.startup — an individual span per manager (WorkManager, FileSystemResourceManager, PathVariableManager, NatureManager, FilterTypeManager, BuildManager, NotificationManager, MarkerManager, SaveManager, PropertyManager2, CharsetManager, ContentDescriptionManager, RefreshManager, AliasManager) plus a total span.
• SaveManager.restore — sub-spans for restoreMasterTable, restoreTree, restoreSnapshots, restoreMarkers, restoreSyncInfo, restoreMetaInfo, and the per-project Project.startup loop.
• InternalPlatform.start — total + sub-spans for openOSGiTrackers, processCommandLine, initializeDebugFlags, initializeAuthorizationHandler, initializeSSLContext, startServices.
• openOSGiTrackers — an individual span per each of the 13 ServiceTracker.open calls.

Dependency

Requires org.eclipse.core.internal.runtime.StartupTrace in org.eclipse.equinox.common. See the companion PR in vogella/equinox. Until that bundle is installed into the local target platform, this branch will not compile downstream bundles via -Pbuild-individual-bundles (Tycho's baseline-replace silently substitutes upstream artifacts).

Scope

Local-only tracing build. Not intended for upstream merge.

Test plan

• Build equinox.common companion PR and install into local target platform (or import via PDE).
• Launch the IDE, exercise workspace open on a real project set, exit cleanly.
• Verify ~/.eclipse/startup-trace.csv contains rows from Workspace/SaveManager/InternalPlatform under a single runId.
• Confirm the stdout top-40 summary lists the instrumented phases.

[gemini-code-assist]

Code Review

This pull request introduces performance instrumentation using the StartupTrace utility across key initialization and restoration methods in SaveManager, Workspace, and InternalPlatform. The review feedback identifies several opportunities to improve the robustness of this instrumentation, specifically by using try-finally blocks to ensure that trace records are captured even when exceptions occur. Additionally, there is a recommendation to maintain consistent naming conventions for trace identifiers in InternalPlatform to match the patterns used in other components.

[gemini-code-assist]

The recording of the Workspace.open and Workspace.open/crashRecoveryRefresh spans is inconsistent and contains duplication.

1. tOpen is recorded manually in the RuntimeException catch block (line 2389) and at the end of the method (line 2399), but it is missed if a CoreException is thrown earlier (e.g., during startup() at line 2376).
2. tRefresh is recorded twice: once in the catch block (line 2388) and once after the try block (line 2394).

Consider wrapping the method body in a try-finally block for tOpen, and using a try-finally for the refresh logic. This ensures all spans are recorded regardless of how the method exits, matching the robust pattern used in SaveManager.restore() and Workspace.startup().

[gemini-code-assist]

The InternalPlatform.start span is only recorded at the very end of the method. If an unchecked exception occurs during startup, the trace will be lost. For better reliability in profiling, consider wrapping the method body in a try-finally block to ensure StartupTrace.record is always called, consistent with the implementation in SaveManager.restore().

[gemini-code-assist]

The trace names in openOSGiTrackers are missing the InternalPlatform. class prefix. This is inconsistent with the naming convention used in other instrumented areas like Workspace.startup/... and SaveManager.restore/.... Adding the prefix will make the trace logs more consistent and easier to aggregate.

	private void openOSGiTrackers() {
		long t;
		t = StartupTrace.begin();
		instanceLocation = createOpenTracker(Location.INSTANCE_FILTER);
		StartupTrace.record("InternalPlatform.openOSGiTrackers/instanceLocation", t); //$NON-NLS-1$
		t = StartupTrace.begin();
		userLocation = createOpenTracker(Location.USER_FILTER);
		StartupTrace.record("InternalPlatform.openOSGiTrackers/userLocation", t); //$NON-NLS-1$
		t = StartupTrace.begin();
		configurationLocation = createOpenTracker(Location.CONFIGURATION_FILTER);
		StartupTrace.record("InternalPlatform.openOSGiTrackers/configurationLocation", t); //$NON-NLS-1$
		t = StartupTrace.begin();
		installLocation = createOpenTracker(Location.INSTALL_FILTER);
		StartupTrace.record("InternalPlatform.openOSGiTrackers/installLocation", t); //$NON-NLS-1$
		t = StartupTrace.begin();
		logTracker = createOpenTracker(FrameworkLog.class);
		StartupTrace.record("InternalPlatform.openOSGiTrackers/FrameworkLog", t); //$NON-NLS-1$
		t = StartupTrace.begin();
		platformTracker = createOpenTracker(PlatformAdmin.class);
		StartupTrace.record("InternalPlatform.openOSGiTrackers/PlatformAdmin", t); //$NON-NLS-1$
		t = StartupTrace.begin();
		contentTracker = createOpenTracker(IContentTypeManager.class);
		StartupTrace.record("InternalPlatform.openOSGiTrackers/IContentTypeManager", t); //$NON-NLS-1$
		t = StartupTrace.begin();
		preferencesTracker = createOpenTracker(IPreferencesService.class);
		StartupTrace.record("InternalPlatform.openOSGiTrackers/IPreferencesService", t); //$NON-NLS-1$
		t = StartupTrace.begin();
		groupProviderTracker = createOpenTracker("(objectClass=" + IBundleGroupProvider.class.getName() + ")"); //$NON-NLS-1$ //$NON-NLS-2$
		StartupTrace.record("InternalPlatform.openOSGiTrackers/IBundleGroupProvider", t); //$NON-NLS-1$
		t = StartupTrace.begin();
		logReaderTracker = createOpenTracker(ExtendedLogReaderService.class);
		StartupTrace.record("InternalPlatform.openOSGiTrackers/ExtendedLogReaderService", t); //$NON-NLS-1$
		t = StartupTrace.begin();
		extendedLogTracker = createOpenTracker(ExtendedLogService.class);
		StartupTrace.record("InternalPlatform.openOSGiTrackers/ExtendedLogService", t); //$NON-NLS-1$
		t = StartupTrace.begin();
		environmentTracker = createOpenTracker(EnvironmentInfo.class);
		StartupTrace.record("InternalPlatform.openOSGiTrackers/EnvironmentInfo", t); //$NON-NLS-1$
		t = StartupTrace.begin();
		debugTracker = createOpenTracker(DebugOptions.class);
		StartupTrace.record("InternalPlatform.openOSGiTrackers/DebugOptions", t); //$NON-NLS-1$
	}