mozjs128: update to 128.14.0#61450
Open
amadaluzia wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Sorry, I just woke up and I did not realise it mostly builds fine. My masterdir is probably borked. Guess I just need to figure out i686. |
Contributor
Author
|
I think this can be merged now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
This is a draft PR. As far as I have seen, this doesn't even build for me yet. I'm looking to work on this more tomorrow but I've taken some of the advice from @JkktBkkt in #59704. Hopefully by the time this is ready to merge, we'll have something building.
Edit: My build environment probably is broken, and CI put that up on display for everyone x3. I didn't think it worked on anything but I'm glad to see I only have to work on i686. Though this is still a draft because of i686.