feat(check): support `--no-error-on-unmatched-pattern` for fmt and lint by fengmk2 · Pull Request #1354 · voidzero-dev/vite-plus

fengmk2 · 2026-04-10T06:00:09Z

Summary

In --fix mode with file paths, implicitly pass --no-error-on-unmatched-pattern to both oxfmt and oxlint, preventing errors when all staged files are excluded by ignorePatterns (the lint-staged use case).
Expose --no-error-on-unmatched-pattern as an explicit CLI flag for non-fix use cases. Both oxfmt and oxlint support this flag natively.
Add snap tests covering: unmatched patterns pass in fix mode, non-lintable files (package.json) pass in fix mode, real lint errors are not swallowed, and vp lint package.json exits non-zero.

Closes #1210

Test plan

pnpm -F vite-plus snap-test-local check-fix-no-error-unmatched — verifies implicit/explicit flag behavior
pnpm -F vite-plus snap-test-local check-fix-lint-error-not-swallowed — verifies real lint errors surface
pnpm -F vite-plus snap-test-local lint-unmatched-pattern — verifies vp lint package.json exits non-zero
pnpm -F vite-plus snap-test-local check — all 25 check snap tests pass
pnpm -F vite-plus snap-test-global command-check-help — help output includes new flag

fengmk2 · 2026-04-10T06:00:26Z

How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

fengmk2 · 2026-04-10T06:07:47Z

@cursor review

leaysgur

BTW, I suspect the output we're getting for now is NOT the intended behavior?
❯ vp check noop
VITE+ - The Unified Toolchain for the Web

error: Formatting could not start
Checking formatting...

Finished in 90ms on 0 files using 8 threads.
No files found matching the given patterns.

Formatting failed before analysis started
pass: Found no warnings, lint errors, or type errors in 0 files (82ms, 8 threads)
vp check [PATH] automatically set vp fmt --no-error-on-unmatched-pattern to surpress error, but it reports error.

Just wondering if this case also fixed?

packages/cli/snap-tests/check-fix-no-error-unmatched/snap.txt

packages/cli/binding/src/check/mod.rs

fengmk2 · 2026-04-10T07:03:19Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit a82d5a0. Configure here.}

netlify · 2026-04-11T08:38:24Z

✅ Deploy Preview for viteplus-preview canceled.

Name	Link
🔨 Latest commit	`7be8a79`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/69df1f99e64f0300087a9150

leaysgur · 2026-04-13T00:36:28Z

FYI: oxc-project/oxc#21144

fengmk2 · 2026-04-13T01:47:30Z

@leaysgur @camc314 Nice! I will wait for oxlint release and add --no-error-on-unmatched-pattern for oxlint. ❤️

camc314 · 2026-04-14T15:45:52Z

@fengmk2 should be ready with 1.60.0! 🙏

In `--fix` mode with file paths, implicitly suppress "no matching files" errors for both fmt and lint. This fixes the lint-staged use case where staged files may be excluded by ignorePatterns (e.g. package-lock.json excluded by fmt ignorePatterns). Also expose `--no-error-on-unmatched-pattern` as an explicit CLI flag for non-fix use cases. oxfmt supports this flag natively; for oxlint (which does not), vp check handles it by treating unparseable lint output as a pass when the flag is active. Closes #1210

Invert the empty if-branch into a negated guard condition. Improve comments to explain the asymmetry between fmt and lint None arms: oxfmt handles the flag natively (exits 0), while oxlint does not (exits non-zero), requiring an explicit status override.

… is active Only suppress lint errors when the output is empty (no files to lint). If oxlint produced error output (config error, crash, etc.), surface it even when --no-error-on-unmatched-pattern is active.

…matched Add snap test that runs `vp check --fix` with paths (activating suppress_unmatched) on a file with a real lint error, confirming the error is still surfaced and the command exits non-zero.

Replace .oxlintrc.json with vite.config.ts in the check-fix-lint-error-not-swallowed snap test to match the preferred configuration style used across other snap tests.

Now that oxlint supports --no-error-on-unmatched-pattern, pass it directly instead of working around it at the vp check level. Simplify the lint None branch to match the fmt pattern. Add snap tests for `vp check --fix package.json` (non-lintable file, should pass) and `vp lint package.json` (should exit non-zero).

fengmk2 · 2026-04-15T05:49:20Z

vp staged fixed now

fengmk2 self-assigned this Apr 10, 2026

This was referenced Apr 10, 2026

feat(installer): add standalone Windows .exe installer (vp-setup.exe) #1293

Merged

refactor: extract check command into its own module #1350

Merged

fengmk2 mentioned this pull request Apr 10, 2026

refactor: split cli.rs into focused submodules #1351

Merged

fengmk2 force-pushed the support-no-error-on-unmatched-pattern branch from 507a843 to c9de266 Compare April 10, 2026 06:00

fengmk2 force-pushed the refactor-cli-others branch from 08a95ab to 8e4d260 Compare April 10, 2026 06:00

fengmk2 marked this pull request as ready for review April 10, 2026 06:01

fengmk2 requested review from cpojer and leaysgur April 10, 2026 06:01

fengmk2 added the test: e2e Auto run e2e tests label Apr 10, 2026 — with Graphite App

leaysgur reviewed Apr 10, 2026

View reviewed changes

fengmk2 commented Apr 10, 2026

View reviewed changes

packages/cli/snap-tests/check-fix-no-error-unmatched/snap.txt Show resolved Hide resolved

cursor bot reviewed Apr 10, 2026

View reviewed changes

packages/cli/binding/src/check/mod.rs Show resolved Hide resolved

fengmk2 mentioned this pull request Apr 10, 2026

fix(cli): exit 0 when all fmt input files are excluded by ignorePatterns #1225

Closed

4 tasks

cursor bot reviewed Apr 10, 2026

View reviewed changes

fengmk2 force-pushed the support-no-error-on-unmatched-pattern branch from a82d5a0 to 584373f Compare April 11, 2026 04:58

fengmk2 force-pushed the refactor-cli-others branch from 8e4d260 to 564d2c4 Compare April 11, 2026 04:58

fengmk2 force-pushed the support-no-error-on-unmatched-pattern branch from 584373f to 81e3f01 Compare April 11, 2026 05:01

fengmk2 force-pushed the refactor-cli-others branch from 564d2c4 to 5f44e05 Compare April 11, 2026 05:01

fengmk2 force-pushed the support-no-error-on-unmatched-pattern branch from 81e3f01 to 2703014 Compare April 11, 2026 05:29

fengmk2 force-pushed the refactor-cli-others branch from 5f44e05 to 27861db Compare April 11, 2026 05:29

graphite-app bot changed the base branch from refactor-cli-others to graphite-base/1354 April 11, 2026 08:23

graphite-app bot force-pushed the graphite-base/1354 branch from 27861db to 18f9f50 Compare April 11, 2026 08:37

graphite-app bot force-pushed the support-no-error-on-unmatched-pattern branch from 2703014 to 53e8b0f Compare April 11, 2026 08:37

graphite-app bot changed the base branch from graphite-base/1354 to main April 11, 2026 08:38

graphite-app bot force-pushed the support-no-error-on-unmatched-pattern branch from 53e8b0f to 10b0678 Compare April 11, 2026 08:38

fengmk2 added 6 commits April 15, 2026 11:03

fix: correct typo unparseable → unparsable

201555e

fix(check): avoid swallowing real lint errors when suppress_unmatched…

d3e2e72

… is active Only suppress lint errors when the output is empty (no files to lint). If oxlint produced error output (config error, crash, etc.), surface it even when --no-error-on-unmatched-pattern is active.

test(check): verify real lint errors are not swallowed by suppress_un…

f4b5a0f

…matched Add snap test that runs `vp check --fix` with paths (activating suppress_unmatched) on a file with a real lint error, confirming the error is still surfaced and the command exits non-zero.

test(check): use vite.config.ts instead of .oxlintrc.json for lint rules

53913e0

Replace .oxlintrc.json with vite.config.ts in the check-fix-lint-error-not-swallowed snap test to match the preferred configuration style used across other snap tests.

fengmk2 force-pushed the support-no-error-on-unmatched-pattern branch from 10b0678 to 40a47e5 Compare April 15, 2026 05:13

fengmk2 changed the title ~~feat(check): support --no-error-on-unmatched-pattern flag~~ feat(check): support --no-error-on-unmatched-pattern for fmt and lint Apr 15, 2026

cpojer approved these changes Apr 15, 2026

View reviewed changes

fengmk2 force-pushed the support-no-error-on-unmatched-pattern branch from 40a47e5 to 7be8a79 Compare April 15, 2026 05:18

fengmk2 merged commit 6e06c17 into main Apr 15, 2026
72 checks passed

fengmk2 deleted the support-no-error-on-unmatched-pattern branch April 15, 2026 05:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(check): support `--no-error-on-unmatched-pattern` for fmt and lint#1354

feat(check): support `--no-error-on-unmatched-pattern` for fmt and lint#1354
fengmk2 merged 7 commits intomainfrom
support-no-error-on-unmatched-pattern

fengmk2 commented Apr 10, 2026 •

edited

Loading

Uh oh!

fengmk2 commented Apr 10, 2026 •

edited

Loading

Uh oh!

fengmk2 commented Apr 10, 2026

Uh oh!

leaysgur left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

fengmk2 commented Apr 10, 2026

Uh oh!

cursor bot left a comment

Uh oh!

netlify bot commented Apr 11, 2026 •

edited

Loading

Uh oh!

leaysgur commented Apr 13, 2026

Uh oh!

fengmk2 commented Apr 13, 2026

Uh oh!

camc314 commented Apr 14, 2026

Uh oh!

fengmk2 commented Apr 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

fengmk2 commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

fengmk2 commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

fengmk2 commented Apr 10, 2026

Uh oh!

leaysgur left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fengmk2 commented Apr 10, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

netlify bot commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-preview canceled.

Uh oh!

leaysgur commented Apr 13, 2026

Uh oh!

fengmk2 commented Apr 13, 2026

Uh oh!

camc314 commented Apr 14, 2026

Uh oh!

fengmk2 commented Apr 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fengmk2 commented Apr 10, 2026 •

edited

Loading

fengmk2 commented Apr 10, 2026 •

edited

Loading

leaysgur left a comment •

edited

Loading

netlify bot commented Apr 11, 2026 •

edited

Loading