Skip to content

test: add tests for sandbox Kind and Namespace properties #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abhinav-kodes wants to merge 2 commits into
base: main
Choose a base branch
from
+43 −21
Open

test: add tests for sandbox Kind and Namespace properties #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce672a9
test: add tests for sandbox Kind and Namespace properties
Abhinav-kodes May 19, 2026
cfc6799
test: fix Kind assertions, add missing assertions and fix lint errors
Abhinav-kodes May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 32 additions & 19 deletions pkg/router/session_manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
"net/http/httptest"
"os"
"path/filepath"
"reflect"
"testing"
"time"

Expand Down Expand Up @@ -157,6 +158,7 @@ func TestGetSandboxBySession_NotFound(t *testing.T) {
// ---- tests: GetSandboxBySession with empty sessionID (sandbox creation path) ----

func TestGetSandboxBySession_CreateSandbox_AgentRuntime_Success(t *testing.T) {
const defaultNS = "default"
// Mock workload manager server
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
// Verify request method and path
Expand All @@ -182,12 +184,13 @@ func TestGetSandboxBySession_CreateSandbox_AgentRuntime_Success(t *testing.T) {
if req.Name != "test-runtime" {
t.Errorf("expected name test-runtime, got %s", req.Name)
}
if req.Namespace != "default" {
t.Errorf("expected namespace default, got %s", req.Namespace)
if req.Namespace != defaultNS {
t.Errorf("expected namespace %s, got %s", defaultNS, req.Namespace)
}

// Send successful response
resp := types.CreateSandboxResponse{
Kind: types.SandboxKind,
SessionID: "new-session-123",
SandboxID: "sandbox-456",
SandboxName: "sandbox-test",
Expand All @@ -208,27 +211,25 @@ func TestGetSandboxBySession_CreateSandbox_AgentRuntime_Success(t *testing.T) {
httpClient: &http.Client{},
}

sandbox, err := m.GetSandboxBySession(context.Background(), "", "default", "test-runtime", types.AgentRuntimeKind)
sandbox, err := m.GetSandboxBySession(context.Background(), "", defaultNS, "test-runtime", types.AgentRuntimeKind)
if err != nil {
t.Fatalf("GetSandboxBySession unexpected error: %v", err)
}
if sandbox == nil {
t.Fatalf("expected non-nil sandbox")
}
if sandbox.SessionID != "new-session-123" {
t.Errorf("expected SessionID new-session-123, got %s", sandbox.SessionID)
}
if sandbox.SandboxID != "sandbox-456" {
t.Errorf("expected SandboxID sandbox-456, got %s", sandbox.SandboxID)
}
if sandbox.Name != "sandbox-test" {
t.Errorf("expected Name sandbox-test, got %s", sandbox.Name)
}
if len(sandbox.EntryPoints) != 1 {
t.Fatalf("expected 1 entry point, got %d", len(sandbox.EntryPoints))
expectedSandbox := &types.SandboxInfo{
Kind: types.SandboxKind,
SandboxNamespace: defaultNS,
SandboxID: "sandbox-456",
Name: "sandbox-test",
SessionID: "new-session-123",
EntryPoints: []types.SandboxEntryPoint{
{Endpoint: "10.0.0.1:9000", Protocol: "http", Path: "/"},
},
}
if sandbox.EntryPoints[0].Endpoint != "10.0.0.1:9000" {
t.Errorf("expected endpoint 10.0.0.1:9000, got %s", sandbox.EntryPoints[0].Endpoint)
if !reflect.DeepEqual(sandbox, expectedSandbox) {
t.Errorf("expected sandbox %+v, got %+v", expectedSandbox, sandbox)
}
}

Expand Down Expand Up @@ -349,6 +350,7 @@ func TestGetSandboxBySession_CreateSandbox_TokenFileReadError(t *testing.T) {
}

func TestGetSandboxBySession_CreateSandbox_CodeInterpreter_Success(t *testing.T) {
const defaultNS = "default"
// Mock workload manager server
mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
// Verify request method and path
Expand All @@ -374,6 +376,7 @@ func TestGetSandboxBySession_CreateSandbox_CodeInterpreter_Success(t *testing.T)

// Send successful response
resp := types.CreateSandboxResponse{
Kind: types.SandboxClaimsKind,
SessionID: "ci-session-789",
SandboxID: "ci-sandbox-101",
SandboxName: "ci-sandbox-test",
Expand All @@ -394,15 +397,25 @@ func TestGetSandboxBySession_CreateSandbox_CodeInterpreter_Success(t *testing.T)
httpClient: &http.Client{},
}

sandbox, err := m.GetSandboxBySession(context.Background(), "", "default", "test-ci", types.CodeInterpreterKind)
sandbox, err := m.GetSandboxBySession(context.Background(), "", defaultNS, "test-ci", types.CodeInterpreterKind)
if err != nil {
t.Fatalf("GetSandboxBySession unexpected error: %v", err)
}
if sandbox == nil {
t.Fatalf("expected non-nil sandbox")
}
if sandbox.SessionID != "ci-session-789" {
t.Errorf("expected SessionID ci-session-789, got %s", sandbox.SessionID)
expectedSandbox := &types.SandboxInfo{
Kind: types.SandboxClaimsKind,
SandboxNamespace: defaultNS,
SandboxID: "ci-sandbox-101",
Name: "ci-sandbox-test",
SessionID: "ci-session-789",
EntryPoints: []types.SandboxEntryPoint{
{Endpoint: "10.0.0.2:8080", Protocol: "http", Path: "/"},
},
}
if !reflect.DeepEqual(sandbox, expectedSandbox) {
t.Errorf("expected sandbox %+v, got %+v", expectedSandbox, sandbox)
}
}

Expand Down
13 changes: 11 additions & 2 deletions pkg/workloadmanager/handlers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func readySandbox() *sandboxv1alpha1.Sandbox {

func makeEntry() *sandboxEntry {
return &sandboxEntry{
Kind: types.AgentRuntimeKind,
Kind: types.SandboxKind,
SessionID: "sess-1",
Ports: []runtimev1alpha1.TargetPort{
{Port: 8080, Protocol: runtimev1alpha1.ProtocolTypeHTTP, PathPrefix: "/api"},
Expand Down Expand Up @@ -242,7 +242,11 @@ func TestServerCreateSandbox(t *testing.T) {
claim = &extensionsv1alpha1.SandboxClaim{ObjectMeta: metav1.ObjectMeta{Name: sb.Name, Namespace: sb.Namespace}}
}

resp, err := server.createSandbox(context.Background(), nil, sb, claim, makeEntry(), resultChan)
entry := makeEntry()
if tt.sandboxClaim {
entry.Kind = types.SandboxClaimsKind
}
resp, err := server.createSandbox(context.Background(), nil, sb, claim, entry, resultChan)

require.Equal(t, tt.expectCreateCalls, createCalls, "createSandbox call count")
require.Equal(t, tt.expectClaimCalls, claimCalls, "createSandboxClaim call count")
Expand All @@ -263,6 +267,11 @@ func TestServerCreateSandbox(t *testing.T) {
require.Equal(t, "sess-1", resp.SessionID)
require.Equal(t, sb.Name, resp.SandboxName)
require.Equal(t, string(sb.UID), resp.SandboxID)
expectedKind := types.SandboxKind
if tt.sandboxClaim {
expectedKind = types.SandboxClaimsKind
}
require.Equal(t, expectedKind, resp.Kind)
require.Len(t, resp.EntryPoints, 1)
Comment thread
Abhinav-kodes marked this conversation as resolved.
require.Equal(t, "/api", resp.EntryPoints[0].Path)
require.Equal(t, "10.0.0.9:8080", resp.EntryPoints[0].Endpoint)
Expand Down
Loading