Skip to content

[release-1.15] Fix hami vGPU scheduling failure in large and medium-scale clusters#5433

Open
Copilot wants to merge 2 commits into
release-1.15from
copilot/release-115
Open

[release-1.15] Fix hami vGPU scheduling failure in large and medium-scale clusters#5433
Copilot wants to merge 2 commits into
release-1.15from
copilot/release-115

Conversation

Copilot AI commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Cherry-pick of aec04d7 to release-1.15. The handshake annotation mechanism between the volcano scheduler and hami-dp caused vGPU scheduling failures in large/medium clusters due to time-inconsistency between scheduler and node.

Changes

  • config/vgpu.go — Remove VolcanoVGPUHandshake constant
  • vgpu/device_info.go — Replace handshake annotation check in NewGPUDevices() with direct node allocatable resource checks (vgpu-number, vgpu-cores, vgpu-memory); node is considered ready for vGPU scheduling only if all three resources are present and non-zero
  • vgpu/utils.go — Remove patchNodeAnnotations() helper (no longer needed)

Before, node readiness depended on a volcano.sh/node-vgpu-handshake annotation being set to "Requesting_<timestamp>" and within a 60s window — a fragile distributed timing assumption. Now it checks node.Status.Allocatable directly, which is authoritative.

@volcano-sh-bot volcano-sh-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 11, 2026
@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 11, 2026
Signed-off-by: fanhy36 <fanhy36@chinaunicom.cn>
@volcano-sh-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jessestutler. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 11, 2026
Copilot AI changed the title [WIP] Cherry-pick changes from commit aec04d7 to release-1.15 cherry-pick: remove handshake between scheduler and hami-dp (release-1.15) Jun 11, 2026
Copilot AI requested a review from JesseStutler June 11, 2026 12:32
@JesseStutler JesseStutler changed the title cherry-pick: remove handshake between scheduler and hami-dp (release-1.15) [release-1.15] Fix hami vGPU scheduling failure in large and medium-scale clusters Jun 11, 2026
@JesseStutler JesseStutler marked this pull request as ready for review June 11, 2026 12:40
@volcano-sh-bot volcano-sh-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 11, 2026
@volcano-sh-bot volcano-sh-bot requested review from hajnalmt and hwdef June 11, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants