Skip to content

fix(parse): recognize .jsonl as a text file so upload encoding normalization applies (#2745) #2794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaojiaSheng merged 1 commit into from
Jun 25, 2026
+6 −0
Merged

fix(parse): recognize .jsonl as a text file so upload encoding normalization applies (#2745) #2794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions openviking/parse/parsers/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@
".properties",
".toml",
".json",
".jsonl",
".yaml",
".yml",
".xml",
Expand Down
5 changes: 5 additions & 0 deletions tests/test_upload_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,11 @@ def test_documentation_extensions(self) -> None:
def test_additional_text_extensions(self) -> None:
assert is_text_file("settings.ini") is True
assert is_text_file("data.csv") is True
# .jsonl is treated as text (matching .json) so upload-time encoding
# normalization applies, mirroring its inclusion in the vectorization
# text-extension set (#2745); otherwise a legacy-encoded .jsonl skips
# UTF-8 normalization while .json does not (#2744/#2770).
assert is_text_file("data.jsonl") is True

def test_non_text_extensions(self) -> None:
assert is_text_file("photo.png") is False
Expand Down
Loading