Updating `volta pin` to support a `--default` flag by charlespierce · Pull Request #52 · volta-cli/rfcs

charlespierce · 2024-02-22T19:13:44Z

Proposal for updating volta pin to add a --default flag that replaces the need for volta install, combining all of the pin operations into a single volta pin command.

Rendered

text/0000-volta-use.md

chriskrycho · 2024-03-15T18:57:35Z

text/0000-volta-use.md

+
+One alternative would be to only change the verb for `install`, leaving `pin` completely untouched. This would be the least disruptive change, however it's very dependent on the verb / command that we choose. With the proposal of `volta use`, it would feel very unintuitive to run `volta use node@21` in a project, and then immediately get a message that it's set as the global but your local settings override. As a user, I would expect `volta use node@21` to mean the next call to `node --version` to display Node 21 is running. In order to make that work as users expect, we need to unify the two so that `volta use` _does_ actually change the Node for the current context.
+
+Another difficulty of the unified behavior is that it's more difficult to explain when users run into edge cases. Right now there's a clear separation between "local" and "global" with two different commands. Unifying them means we'll need to clearly document how `volta use` behaves in each situation, and how to override that (with the `--global` or `--pin` flags).


This is basically exactly my point above. 😂 I take it to be the most significant drawback, and I think it is the thing which really mashes my buttons.

chriskrycho · 2024-03-15T18:58:26Z

text/0000-volta-use.md

+## `volta default` or `volta global`
+
+In the vein of replacing the verb for `install`, I also considered `default` or `global` for the command. The major issue with those is that they're adjectives, rather than verbs, so it's not immediately clear what the command means. Does `volta default node` mean "choose a default node" or "list the current default node"? That confusion is ultimately why I decided against using either of these for the command.
+
+## `volta set`
+
+Another possibility for the command would be to make it more verbose, e.g. `volta set default node`. That solves the problems around `volta default` or `volta global` by adding a verb to make it very clear what you are doing. However, it makes the commands a fair bit more cumbersome to use, which I feel is ultimately a net negative compared to a single command.


👍🏼 to these; I agree quite strongly!

text/0000-volta-use.md

charlespierce · 2024-07-10T03:50:13Z

Suggestion from the main Volta repo: Having volta use be an alias for this combined command would be useful for people switching from / used to nvm, since nvm use is used to change Node versions. It's not exactly the same semantics, so we might want to consider how different it is and how difficult it will be to transition, but I think if we combine the commands it would be a good time to look at making use another alias for the same command.

chriskrycho · 2024-09-10T13:58:01Z

I definitely don’t have an objection to use, @charlespierce; do you remember why we didn’t choose that in the first place? (I believe that decision preceded my working on the project, but it has been a minute, so one way or another I simply do not recall.)

charlespierce · 2024-10-03T16:40:10Z

Updated to a new proposal of continuing to use volta pin with an explicit flag (currently --default) for pinning the default version.

rwjblue · 2024-10-03T16:50:13Z

@charlespierce - I really like this last round of updates, definitely makes more sense to me this way.

charlespierce · 2024-10-03T17:08:36Z

I definitely don’t have an objection to use, @charlespierce; do you remember why we didn’t choose that in the first place? (I believe that decision preceded my working on the project, but it has been a minute, so one way or another I simply do not recall.)

I don't have a deep recollection, but I think we actually did have notion use as a command very early on (that's how long ago it was, prior to the rename). I can't find the git history of why we removed it, likely because it caused more confusion due to the differences with nvm

'volta use' to replace 'install' and 'pin'

fd91308

charlespierce commented Feb 22, 2024

View reviewed changes