fix(nvidia_nim_client): Add missing elif priority == 'cloud' block and fix nim_result scope bug#1
fix(nvidia_nim_client): Add missing elif priority == 'cloud' block and fix nim_result scope bug#1kilo-code-bot[bot] wants to merge 5 commits into
Conversation
kilo-code-bot
Bot
force-pushed
the
gt/toast/308f67fd
branch
from
eff44b9 to
bf1f5df
Compare
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| return result | ||
|
|
||
| elif priority == "heavy": | ||
| elif priority == "heavy": |
There was a problem hiding this comment.
CRITICAL: Missing indentation on elif priority == "heavy" - this is now at module scope outside the call method, causing an IndentationError at runtime. The elif must be indented to be inside the call function.
| ) | ||
| return result | ||
|
|
||
| elif priority == "cloud": |
There was a problem hiding this comment.
CRITICAL: Duplicate elif priority == "cloud" block - dead code that will never execute. The first elif priority == "cloud" block handling (lines 1169-1188) already catches this priority, so this second block at line 1218 is unreachable.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by laguna-m.1-20260312:free · 977,093 tokens |
|
The reported issues have been fixed:
Verified by Kilo Code Review: 'The previous CRITICAL issues have been fixed' - priority routing chain confirmed correct. Note: node-phase-regression CI failure is due to GitHub account billing lock (not a code issue). GitGuardian and Kilo Code Review both passed. |
…ructure for priority routing
The previously reported issues have been fixed in commit df3de9e: - Fixed indentation on elif priority == 'heavy' (now inside call method) - Removed duplicate elif priority == 'cloud' block (dead code eliminated) The Kilo Code Review confirmed: 'The previous CRITICAL issues have been fixed' Priority routing chain verified correct: - if priority == 'local' (lines 1141-1167) - elif priority == 'cloud' (lines 1169-1188) - elif priority == 'heavy' (lines 1190-1216) - else fallback (lines 1218-1229) Note: node-phase-regression CI failure is due to GitHub account billing lock, not a code issue. GitGuardian Security Checks and Kilo Code Review both passed.
vortsghost2025
force-pushed
the
gt/toast/308f67fd
branch
from
29e14ed to
b39de95
Compare
1 participant
This bead fixes two issues in nvidia_nim_client.py:\n1. Missing
elif priority == "cloud"block in the call method.\n2. Thereturn nim_resultstatement was outside the if/elif blocks, causing UnboundLocalError for cloud priority.\n\nThe fix adds the cloud priority block and moves the return statements inside each conditional block.\n\nThis resolves the UnboundLocalError when priority is set to "cloud".