Merged
Conversation
Embed `init` within `Fynix::new()`
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nixonyh
force-pushed
the
nixon/nested-style-deletion
branch
from
bf3afbe to
2435f3b
Compare
ian-hon
reviewed
Apr 27, 2026
| /// `children[0]` is one depth deeper (inner scope). | ||
| /// `children[1]` is same depth, subsequent style node. | ||
| children: [Option<StyleId>; 2], | ||
| adjacent_child: Option<StyleId>, |
Contributor
There was a problem hiding this comment.
Nice! Thanks for updating the implementation to this
ian-hon
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing an element without a
primary_stylewill leave a child element withprimary_styleuntouched. This PR fixes that by moving the style deletion directly withinElement::remove.