Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Removes fynix's hand-rolled layout.rs and moves Size, Vec2, Constraint, and the Layouter trait into rectree, replacing rectree's Option<f64>-based Constraint and kurbo::Size/Vec2. Fynix re-exports rectree at its crate root; fynix_elements imports layout types through fynix::rectree. Removes the kurbo dependency from the rectree crate (spatree retains its own kurbo dep). Also cleans up dead code in Elements and wires up get_dyn via ElementTypeMeta.
The work is mostly done now
ian-hon
commented
Apr 3, 2026
- `Resources::scope` temporarily removes a resource, passes it mutably alongside the remaining `Resources` into a closure, then reinserts it - `Resources::insert` and `init` now return `&mut Self` for builder chaining - Expose `Fynix::elements`, `styles`, `resources`, `resources_mut` - Make `Elements::elements`, `metas`, `type_metas` pub - Add `fynix_elements::init_resources` to initialize `TextContext` - Add `hello_world` example verifying `Label` allocates non-zero size
- Remove `ctx.scope()` from status table (superseded by `Resources::scope` and `add_with` style scoping) - Fix duplicate `compose_hierarchy` examples - rename to `compose_hierarchy_bevy` and `compose_hierarchy_custom` with distinct bodies and update the expansion static name - Move orphaned Bevy consumer system snippet into the `Events queue` subsection where it belongs - Extract `fn main()` startup snippet from inside the `TypeSlotEntry` code block into its own fenced block - Fix double blank line before `## Signals` Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nixonyh
requested changes
Apr 3, 2026
Member
nixonyh
left a comment
nixonyh
left a comment
There was a problem hiding this comment.
Great job! I'd like to see some of the comments addressed, otherwise, it's good to go 🐱.
nixonyh
reviewed
Apr 3, 2026
Co-authored-by: Nixon <43715558+nixonyh@users.noreply.github.com>
nixonyh
reviewed
Apr 11, 2026
| @@ -0,0 +1,34 @@ | |||
| use fynix::ctx::FynixCtx; | |||
| use fynix::element::Element; | |||
| use fynix::{Fynix, fynix}; | |||
Member
There was a problem hiding this comment.
We may need a use fynix::prelude::*; soon xd.
Member
|
I'd approve this once we migrate from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.