Skip to content

fix: correct to_timestamp parameter typing for PG17/EDB #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ovaris wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct to_timestamp parameter typing for PG17/EDB #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ module.exports = function connectPgSimple (session) {
* @access public
*/
pruneSessions (fn) {
this.query('DELETE FROM ' + this.quotedTable() + ' WHERE expire < to_timestamp($1)', [currentTimestamp()], err => {
this.query('DELETE FROM ' + this.quotedTable() + ' WHERE expire < pg_catalog.to_timestamp($1::double precision)', [currentTimestamp()], err => {
if (fn && typeof fn === 'function') {
return fn(err);
}
Expand Down Expand Up @@ -361,7 +361,7 @@ module.exports = function connectPgSimple (session) {
get (sid, fn) {
this.#initPruneTimer();

this.query('SELECT sess FROM ' + this.quotedTable() + ' WHERE sid = $1 AND expire >= to_timestamp($2)', [sid, currentTimestamp()], (err, data) => {
this.query('SELECT sess FROM ' + this.quotedTable() + ' WHERE sid = $1 AND expire >= pg_catalog.to_timestamp($2::double precision)', [sid, currentTimestamp()], (err, data) => {
if (err) { return fn(err); }
// eslint-disable-next-line unicorn/no-null
if (!data) { return fn(null); }
Expand All @@ -386,7 +386,7 @@ module.exports = function connectPgSimple (session) {
this.#initPruneTimer();

const expireTime = this.#getExpireTime(sess);
const query = 'INSERT INTO ' + this.quotedTable() + ' (sess, expire, sid) SELECT $1, to_timestamp($2), $3 ON CONFLICT (sid) DO UPDATE SET sess=$1, expire=to_timestamp($2) RETURNING sid';
const query = 'INSERT INTO ' + this.quotedTable() + ' (sess, expire, sid) SELECT $1, pg_catalog.to_timestamp($2::double precision), $3 ON CONFLICT (sid) DO UPDATE SET sess=$1, expire=pg_catalog.to_timestamp($2::double precision) RETURNING sid';

this.query(
query,
Expand Down Expand Up @@ -432,7 +432,7 @@ module.exports = function connectPgSimple (session) {
const expireTime = this.#getExpireTime(sess);

this.query(
'UPDATE ' + this.quotedTable() + ' SET expire = to_timestamp($1) WHERE sid = $2 RETURNING sid',
'UPDATE ' + this.quotedTable() + ' SET expire = pg_catalog.to_timestamp($1::double precision) WHERE sid = $2 RETURNING sid',
[expireTime, sid],
err => { fn && fn(err); }
);
Expand Down
Loading