Improve viewer class (fully qualify ht_crypt)#88
Improve viewer class (fully qualify ht_crypt)#88DLeich wants to merge 2 commits intovoxpupuli:masterfrom
Conversation
|
Can I get a review on this? This PR replaces #58, which had to be reauthored due to a multitude of merge conflicts. |
|
@DLeich thanks for the work. can you please rebase against our master branch so the merge commit disappears? |
|
Okay this is odd. I just tested trying to rebase, and even just remove my commits for the README.md on a separate personal branch which worked, but on this branch & PR, it still adds them back, so now we have a number of extra commits which are unnecessary. Let me see if I can squash the last handful of commits to make this cleaner. |
|
@bastelfreak - got the rebase situation resolved. I think this is ready now. |
| htpasswd: https://github.com/citrininfo/puppet-htpasswd.git | ||
| vcsrepo: https://github.com/puppetlabs/puppetlabs-vcsrepo.git | ||
| git: https://github.com/puppetlabs-toy-chest/puppetlabs-git.git | ||
| concat: https://github.com/puppetlabs/puppetlabs-concat.git |
There was a problem hiding this comment.
@DLeich might it be better to refer to the Forge versions, instead of the bleeding edge versions on GitHub?
There was a problem hiding this comment.
no :) we refer to master/main branch for unit tests, so wen can detect breaking changes in dependencies before they are released. for acceptance tests we use the latest versions, that the metadata.json accepts, from the forge (this module currently has no acceptance tests but I will add them later
There was a problem hiding this comment.
Right on! Makes sense.
I've got a module I've been struggling to add acceptance tests to; would love to see how you do that here or elsewhere.
3 participants
Pull Request (PR) description
The viewer class was failing to compile when used on puppet 7. This is because the ht_crypt function usage needed to be fully qualified.