add support for Sensitive type in Environment#98
Open
gmenuel wants to merge 1 commit intovoxpupuli:masterfrom
Open
add support for Sensitive type in Environment#98gmenuel wants to merge 1 commit intovoxpupuli:masterfrom
gmenuel wants to merge 1 commit intovoxpupuli:masterfrom
Conversation
Collaborator
|
Isn't #94 the correct thing to do here really. |
Author
|
Yes using podman secret is probably cleaner, this is just easier to use, and since it was really not complicated to implement I thought it could be useful (it is at least for me 🙂) |
Collaborator
|
[like] Steve Traylen reacted to your message:
…________________________________
From: Gregoire Menuel ***@***.***>
Sent: Tuesday, February 17, 2026 2:22:12 PM
To: voxpupuli/puppet-quadlets ***@***.***>
Cc: Steve Traylen ***@***.***>; Comment ***@***.***>
Subject: Re: [voxpupuli/puppet-quadlets] add support for Sensitive type in Environment (PR #98)
[https://avatars.githubusercontent.com/u/22345278?s=20&v=4]gmenuel left a comment (voxpupuli/puppet-quadlets#98)<#98 (comment)>
Yes using podman secret is probably cleaner, this is just easier to use, and since it was really not complicated to implement I thought it could be useful (it is at least for me 🙂)
—
Reply to this email directly, view it on GitHub<#98 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AABBAJIKXVKI4VCEKL6RKU34MMPZJAVCNFSM6AAAAACVM3PHQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMJUHE3TMMZVHA>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Collaborator
|
Hi, Could you add a new acceptance test case for this. Just to confirm nothing blows up later in the templates or something. Otherwise fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Sometimes it is useful to set an environment variable containing sensitive information. This PR add the support for the Sensitive type in the Environment field of the container block.
This Pull Request (PR) fixes the following issues
n/a