Reset State for top-level Views only - #1540
Closed
rolandhill wants to merge 1 commit into
Closed
Conversation
Collaborator
|
I don't think this PR is the right approach so I'll close this PR. I feel that using State::dirtyStateStacks() is more appropriate: 7dfa833 If the change to dirtyStateStacks() doesn't work for your app we can investigate further, this will require creating an test program to reproduce the issues you're seeing. |
Contributor
Author
|
State::dirtyStateStacks() works for me. I'm happy to go with that if it also works for @theodoregoetz . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset state every time the RecordTraversal encounters a top-level View.
State needs to be reset between sibling top-level Views, otherwise it is left in an undefined status, which can lead to state not being recorded when using lazy state updating. However, some implementations using nested Views require state to persist from parent View to child View.
This PR modifies #1502 so that only top-level State is reset instead of resetting it for all Views. This addresses #1538