Add more e2e RBAC#1199
Merged
Merged
Conversation
Kidswiss
force-pushed
the
fix/e2e-rbac
branch
2 times, most recently
from
7b3758e to
682a866
Compare
Kidswiss
requested review from
a team,
TheBigLee,
mdnix,
mikeshootzz and
zugao
and removed request for
a team
mikeshootzz
reviewed
May 29, 2026
| ownerGroup: appcat.vshn.io | ||
| ownerKind: XObjectBucket | ||
| ownerVersion: v1 | ||
| proxyEndpoint: 172.18.0.1:9443 |
Contributor
There was a problem hiding this comment.
this looks unrelated 🤔
Contributor
Author
There was a problem hiding this comment.
This is handled by make push-golden depending if you pass the -e DEBUG=false or not, but I can reset it.
| registry: dockerhub.vshn.net | ||
| grpcEndpoint: 172.18.0.1:9443 | ||
| proxyFunction: true | ||
| proxyFunction: false |
Contributor
Author
|
Link to passing e2e tests: https://github.com/vshn/component-appcat/actions/runs/26635484023 |
mikeshootzz
approved these changes
May 29, 2026
Because kuttl tries to read service accounts from the default namespace for some reason, we added RBAC to allow this. Otherwise it spends a lot of time re-trying to query those service accounts. Also fixing a few postgresqlcnpg issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because kuttl tries to read service accounts from the default namespace for some reason, we added RBAC to allow this.
Otherwise it spends a lot of time re-trying to query those service accounts.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
make e2e-testagainst local kindev and all checks passed