Add timeout to batch modal update response#197
Open
vhaalmeida wants to merge 4 commits intomasterfrom
Open
Conversation
wagnerlduarte
requested changes
Sep 19, 2023
apps/vtex-my-subscriptions-3/react/components/AddItemModal/Modal.tsx
Outdated
Show resolved
Hide resolved
| }) | ||
| } | ||
| // timeout added due to state not update instantaneously | ||
| setTimeout(() => { |
Contributor
There was a problem hiding this comment.
I believe you used setTimeout as a workaround to ensure that the state is updated.
Although it works, it may be better to transform the handleSuccess function into a Promise, to make this state update guarantee better.
Can you test whether removing setTimeout and changing handleSuccess to a Promise works well?
private handleSuccess = (id: string) => {
return new Promise<void>((resolve) => {
this.setState(({ completed }) => {
completed.push(id);
return { completed };
}, resolve);
});
}
…al.tsx Co-authored-by: Wagner Lemos Duarte <wagner.duarte@vtex.com.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? *
Add a timeout to handle state after update. Without it the error modal is displayed even when all requests went ok.
Without timeout:


How to test it? *
Related to / Depends on *