Ci/add package release api and build from cache#496
Open
anthonyronda wants to merge 2 commits intomainfrom
Open
Ci/add package release api and build from cache#496anthonyronda wants to merge 2 commits intomainfrom
anthonyronda wants to merge 2 commits intomainfrom
Conversation
wyrmisis
reviewed
Feb 8, 2024
Comment on lines
+86
to
+88
| "minimum": "11", | ||
| "verified": "11", | ||
| "maximum": "11" |
Collaborator
There was a problem hiding this comment.
It'd be cool if these could be dynamically set somehow so we can leave our CI file alone when a new Foundry version comes out.
Member
Author
There was a problem hiding this comment.
You make a good point. This will be fixed before I merge this. We're already manipulating fields in the manifest before submitting to the API, so we might as well grab these
Member
Author
|
Using this to preserve environment variables between steps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to use this API in CI
https://foundryvtt.com/article/package-release-api/
and re-enables building from cache in CI after this fix
League-of-Foundry-Developers/foundry-vtt-types#2398
(League's Foundry Types has a husky dependency, and husky wants to run scripts upon install–we don't want it to–and it used to error out our build script because it can't find the working directory from its cached directory)