test: build runtime-vapor in cjs for pkg.pr.new#14418
test: build runtime-vapor in cjs for pkg.pr.new#14418zhiyuanzmj wants to merge 4 commits intovuejs:minorfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
Size ReportBundles
Usages
|
There was a problem hiding this comment.
Pull request overview
This PR attempts to include runtime-vapor exports in CJS builds for pkg.pr.new testing. However, the implementation has significant architectural issues.
Changes:
- Disables the trimVaporExportsPlugin that normally excludes vapor exports from non-vapor builds
- Adds vapor exports to standard runtime.ts and index.ts files
- Removes vapor exports from the files specifically named "with-vapor"
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/trim-vapor-exports.js | Comments out the plugin that trims vapor exports from runtime builds |
| packages/vue/src/runtime.ts | Adds vapor exports to the standard runtime-only build |
| packages/vue/src/runtime-with-vapor.ts | Removes direct vapor export (but still includes it via runtime.ts import) |
| packages/vue/src/index.ts | Adds vapor exports to the standard full build with compiler |
| packages/vue/src/index-with-vapor.ts | Removes direct vapor export (but still includes it via index.ts import) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
just a test