Report technical debt findings for core packages#14463
Open
poria-lang wants to merge 2 commits intovuejs:mainfrom
Open
Report technical debt findings for core packages#14463poria-lang wants to merge 2 commits intovuejs:mainfrom
poria-lang wants to merge 2 commits intovuejs:mainfrom
Conversation
Provides a list of tasks for technical debt fixes and test gaps in runtime-core, reactivity, and compiler-sfc. Co-authored-by: poria-lang <216370060+poria-lang@users.noreply.github.com>
…82389439833 Report technical debt findings for core packages
Contributor
|
This PR seems to be missing the actual changes. I can see them in poria-lang@051ae44 but that commit hasn't been included in the PR. These appear to be several independent changes, so I would recommend opening a separate PR for each change so they can be assessed individually, rather than bundling them together. I could be wrong, but this looks like AI-generated code, and while some of the changes make sense, for others it isn't clear to me what value they're adding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses several technical debt items and improvements identified during a deep-scan of the core packages:
Reactivity:
isProxysignature updated to useunknowninstead ofanyfor better type safety.traverseutility to ensure robustness in deep-watching logic, including a test for traversal depth.Compiler-SFC:
SupportedBuiltinsSet.hascheck to use proper type casting, removing@ts-expect-errorandany.Runtime-Core:
flushPostFlushCbsin the scheduler by usingArray.frominstead of array spreading for Set conversion, reducing unnecessary spread operations in a hot path.slotsandattrsin component inspection and display the component name in the header, fulfilling a long-standing TODO.All changes have been verified with existing and new unit tests, and the entire project passes type checking (
tsc).