Skip to content

fix(compiler-vapor): preserve :is prop on normal components#14491

Merged
edison1105 merged 1 commit intominorfrom
edison/fix/14488
Mar 2, 2026
Merged

fix(compiler-vapor): preserve :is prop on normal components#14491
edison1105 merged 1 commit intominorfrom
edison/fix/14488

Conversation

@edison1105
Copy link
Member

@edison1105 edison1105 commented Feb 28, 2026

close #14488

Summary by CodeRabbit

  • Tests

    • Added comprehensive test coverage for dynamic component :is binding behavior.
  • Bug Fixes

    • Refined dynamic component property handling to correctly process the :is prop when used alongside static is attributes.

@coderabbitai
Copy link

coderabbitai bot commented Feb 28, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/14488

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 28, 2026

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14491
npm i https://pkg.pr.new/@vue/compiler-core@14491
yarn add https://pkg.pr.new/@vue/compiler-core@14491.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14491
npm i https://pkg.pr.new/@vue/compiler-dom@14491
yarn add https://pkg.pr.new/@vue/compiler-dom@14491.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14491
npm i https://pkg.pr.new/@vue/compiler-sfc@14491
yarn add https://pkg.pr.new/@vue/compiler-sfc@14491.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14491
npm i https://pkg.pr.new/@vue/compiler-ssr@14491
yarn add https://pkg.pr.new/@vue/compiler-ssr@14491.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14491
npm i https://pkg.pr.new/@vue/compiler-vapor@14491
yarn add https://pkg.pr.new/@vue/compiler-vapor@14491.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14491
npm i https://pkg.pr.new/@vue/reactivity@14491
yarn add https://pkg.pr.new/@vue/reactivity@14491.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14491
npm i https://pkg.pr.new/@vue/runtime-core@14491
yarn add https://pkg.pr.new/@vue/runtime-core@14491.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14491
npm i https://pkg.pr.new/@vue/runtime-dom@14491
yarn add https://pkg.pr.new/@vue/runtime-dom@14491.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14491
npm i https://pkg.pr.new/@vue/runtime-vapor@14491
yarn add https://pkg.pr.new/@vue/runtime-vapor@14491.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14491
npm i https://pkg.pr.new/@vue/server-renderer@14491
yarn add https://pkg.pr.new/@vue/server-renderer@14491.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14491
npm i https://pkg.pr.new/@vue/shared@14491
yarn add https://pkg.pr.new/@vue/shared@14491.tgz

vue

pnpm add https://pkg.pr.new/vue@14491
npm i https://pkg.pr.new/vue@14491
yarn add https://pkg.pr.new/vue@14491.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14491
npm i https://pkg.pr.new/@vue/compat@14491
yarn add https://pkg.pr.new/@vue/compat@14491.tgz

commit: 331efaf

@github-actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 86.4 kB 30.2 kB 26.6 kB
runtime-dom.global.prod.js 110 kB 41.6 kB 37.3 kB
vue.global.prod.js 169 kB 61.4 kB 54.7 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 50.3 kB 19.7 kB 17.9 kB
createApp 59.3 kB 23 kB 20.9 kB
createApp + vaporInteropPlugin 82.6 kB 30.7 kB 27.8 kB
createVaporApp 28.6 kB 11.1 kB 10.2 kB
createSSRApp 63.5 kB 24.7 kB 22.5 kB
createVaporSSRApp 32 kB 12.4 kB 11.4 kB
defineCustomElement 65.3 kB 24.8 kB 22.5 kB
defineVaporCustomElement 38.9 kB 14.4 kB 13.2 kB
overall 74.2 kB 28.3 kB 25.7 kB

@edison1105 edison1105 added the scope: vapor related to vapor mode label Feb 28, 2026
@edison1105 edison1105 moved this to Vapor in Next Minor Feb 28, 2026
@edison1105 edison1105 merged commit c763388 into minor Mar 2, 2026
22 of 23 checks passed
@edison1105 edison1105 deleted the edison/fix/14488 branch March 2, 2026 05:54
@github-project-automation github-project-automation bot moved this from Vapor to Done in Next Minor Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: vapor related to vapor mode

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Vapor] The prop is of Vapor components does not support dynamic binding via v-bind

1 participant