Fix my_glob crash from macOS resource fork files#68
Open
alptaciroglu wants to merge 1 commit into
Open
Conversation
On macOS (and occasionally Linux), ._* files on external volumes cause Flysystem's directory listing to throw UnableToListContents. Add a fallback to native scandir that skips these files, preserving the Storage-relative path format all callers expect. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Helper::my_glob()crashes withUnableToListContentswhen macOS._(AppleDouble/resource fork) files exist in the job directory — these files can't be stat'd by Flysystem'sLocalFilesystemAdapterscandir()that skips._*files, preserving the Storage-relative path format all callers expectThis affects anyone running FUMA locally on macOS, particularly with external volumes (e.g. USB drives) where
._files are common. The visible symptom is a "JobQuery MAGMA_expPlot error" alert on SNP2GENE results pages.Test plan
._test_filein a job directory, confirmed MAGMA expression plot renders without errormy_globcallers (S2GController, CellController, FumaController) receive paths in the same format🤖 Generated with Claude Code