Skip to content

fix: sanitize image filenames for writing to disk#11

Open
tin900 wants to merge 1 commit intomainfrom
10-bug-download_filtered_tableau_image-having-certain-special-characters-eg-in-filter-values-causes-error
Open

fix: sanitize image filenames for writing to disk#11
tin900 wants to merge 1 commit intomainfrom
10-bug-download_filtered_tableau_image-having-certain-special-characters-eg-in-filter-values-causes-error

Conversation

@tin900
Copy link
Copy Markdown
Contributor

@tin900 tin900 commented Sep 9, 2024

Pull Request Description

Type of Change

  • Bug fix
  • New feature
  • Enhancement
  • Documentation update
  • Other (please specify)

Description of Changes

Before writing files to disk, replace special characters which are forbidden in filepaths, by an underscore.

Related Issues

See associated issue #10

Checklist

  • I have tested these changes locally
  • I have updated the documentation accordingly
  • My code follows the project's coding standards
  • I have added/updated tests to cover my changes (if applicable)
  • The code is accompanied by comments
  • I have linked this PR to relevant issues (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] download_filtered_tableau_image(): having certain special characters (e.g. :) in filter values causes error

1 participant