Skip to content

Security and Bug Fixes #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asdek merged 3 commits into from
Feb 21, 2026
Merged

Security and Bug Fixes #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c1f5e7
Security and Bug Fixes
mrigankad Feb 20, 2026
6ba22d6
Reviewer-requested changes: remove server-side password change block …
mrigankad Feb 21, 2026
ec4a24d
Remove .claude folder and add to .gitignore
mrigankad Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,5 @@ build/*
data/*
.bak/*
!.gitkeep
.claude/

9 changes: 9 additions & 0 deletions backend/pkg/server/auth/auth_middleware.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"fmt"
"slices"
"strings"
"time"

"pentagi/pkg/server/models"
"pentagi/pkg/server/response"
Expand Down Expand Up @@ -104,6 +105,14 @@ func (p *AuthMiddleware) tryUserCookieAuthentication(c *gin.Context) (authResult
return authResultFail, errors.New("no pemissions granted")
}

expVal, ok := exp.(int64)
if !ok {
return authResultFail, errors.New("token claim invalid")
}
if time.Now().Unix() > expVal {
return authResultFail, errors.New("session expired")
}

c.Set("prm", prms)
c.Set("uid", uid.(uint64))
c.Set("uhash", uhash.(string))
Expand Down
13 changes: 12 additions & 1 deletion backend/pkg/server/services/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ func (s *AuthService) AuthLogin(c *gin.Context) {
session.Options(sessions.Options{
HttpOnly: true,
Secure: c.Request.TLS != nil,
SameSite: http.SameSiteLaxMode,
Path: s.cfg.BaseURL,
MaxAge: int(expires),
})
Expand Down Expand Up @@ -195,6 +196,7 @@ func (s *AuthService) refreshCookie(c *gin.Context, resp *info, privs []string)
session.Options(sessions.Options{
HttpOnly: true,
Secure: c.Request.TLS != nil,
SameSite: http.SameSiteLaxMode,
Path: s.cfg.BaseURL,
MaxAge: expires,
})
Expand Down Expand Up @@ -325,6 +327,12 @@ func (s *AuthService) AuthLoginGetCallback(c *gin.Context) {
return
}

if queryState := c.Query("state"); queryState != "" && queryState != state.Value {
logger.FromContext(c).Errorf("error matching received state to stored one")
response.Error(c, response.ErrAuthInvalidAuthorizationState, nil)
return
}

stateData, err := s.parseState(c, state.Value)
if err != nil {
return
Expand Down Expand Up @@ -546,6 +554,7 @@ func (s *AuthService) authLoginCallback(c *gin.Context, stateData map[string]str
session.Options(sessions.Options{
HttpOnly: true,
Secure: c.Request.TLS != nil,
SameSite: http.SameSiteLaxMode,
Path: s.cfg.BaseURL,
MaxAge: expires,
})
Expand Down Expand Up @@ -597,13 +606,13 @@ func (s *AuthService) parseState(c *gin.Context, state string) (map[string]strin
}

signatureLen := 32
stateSignature := stateJSON[:signatureLen]
if len(stateJSON) <= signatureLen {
logger.FromContext(c).Errorf("error on parsing state from json data")
err := fmt.Errorf("unexpected state length")
response.Error(c, response.ErrAuthInvalidAuthorizationState, err)
return nil, err
}
stateSignature := stateJSON[:signatureLen]
stateJSON = stateJSON[signatureLen:]

mac := hmac.New(sha256.New, s.key)
Expand Down Expand Up @@ -646,6 +655,7 @@ func (s *AuthService) setCallbackCookie(w http.ResponseWriter, r *http.Request,
Value: value,
HttpOnly: true,
Secure: r.TLS != nil,
SameSite: http.SameSiteLaxMode,
Path: path.Join(s.cfg.BaseURL, s.cfg.LoginCallbackURL),
MaxAge: maxAge,
}
Expand All @@ -660,6 +670,7 @@ func (s *AuthService) resetSession(c *gin.Context) {
session.Options(sessions.Options{
HttpOnly: true,
Secure: c.Request.TLS != nil,
SameSite: http.SameSiteLaxMode,
Path: s.cfg.BaseURL,
MaxAge: -1,
})
Expand Down
4 changes: 2 additions & 2 deletions backend/pkg/server/services/roles.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func (s *RoleService) GetRoles(c *gin.Context) {
rid := c.GetUint64("rid")
privs := c.GetStringSlice("prm")
scope := func(db *gorm.DB) *gorm.DB {
if !slices.Contains(privs, "roles.view'") {
if !slices.Contains(privs, "roles.view") {
return db.Where("role_id = ?", rid)
}
return db
Expand Down Expand Up @@ -128,7 +128,7 @@ func (s *RoleService) GetRole(c *gin.Context) {
rid := c.GetUint64("rid")
privs := c.GetStringSlice("prm")
scope := func(db *gorm.DB) *gorm.DB {
if !slices.Contains(privs, "roles.view'") {
if !slices.Contains(privs, "roles.view") {
return db.Where("role_id = ?", rid)
}
return db
Expand Down
14 changes: 7 additions & 7 deletions backend/pkg/server/services/users.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ func (s *UserService) GetUsers(c *gin.Context) {
uid := c.GetUint64("uid")
privs := c.GetStringSlice("prm")
scope := func(db *gorm.DB) *gorm.DB {
if !slices.Contains(privs, "users.view'") {
if !slices.Contains(privs, "users.view") {
return db.Where("id = ?", uid)
}
return db
Expand Down Expand Up @@ -257,7 +257,7 @@ func (s *UserService) GetUser(c *gin.Context) {

uhash := c.GetString("uhash")
privs := c.GetStringSlice("prm")
if !slices.Contains(privs, "users.view'") && uhash != hash {
if !slices.Contains(privs, "users.view") && uhash != hash {
logger.FromContext(c).Errorf("error filtering user role permissions: permission not found")
response.Error(c, response.ErrNotPermitted, nil)
return
Expand Down Expand Up @@ -318,7 +318,7 @@ func (s *UserService) CreateUser(c *gin.Context) {

rid := c.GetUint64("rid")
privs := c.GetStringSlice("prm")
if !slices.Contains(privs, "users.create'") {
if !slices.Contains(privs, "users.create") {
logger.FromContext(c).Errorf("error filtering user role permissions: permission not found")
response.Error(c, response.ErrNotPermitted, nil)
return
Expand Down Expand Up @@ -423,13 +423,13 @@ func (s *UserService) PatchUser(c *gin.Context) {
uhash := c.GetString("uhash")
privs := c.GetStringSlice("prm")
scope := func(db *gorm.DB) *gorm.DB {
if slices.Contains(privs, "users.edit'") {
if slices.Contains(privs, "users.edit") {
return db.Where("hash = ?", hash)
} else {
return db.Where("hash = ? AND id = ?", hash, uid)
}
}
if !slices.Contains(privs, "users.edit'") && uhash != hash {
if !slices.Contains(privs, "users.edit") && uhash != hash {
logger.FromContext(c).Errorf("error filtering user role permissions: permission not found")
response.Error(c, response.ErrNotPermitted, nil)
return
Expand Down Expand Up @@ -510,13 +510,13 @@ func (s *UserService) DeleteUser(c *gin.Context) {
uhash := c.GetString("uhash")
privs := c.GetStringSlice("prm")
scope := func(db *gorm.DB) *gorm.DB {
if slices.Contains(privs, "users.delete'") {
if slices.Contains(privs, "users.delete") {
return db.Where("hash = ?", hash)
} else {
return db.Where("hash = ? AND id = ?", hash, uid)
}
}
if !slices.Contains(privs, "users.delete'") && uhash != hash {
if !slices.Contains(privs, "users.delete") && uhash != hash {
logger.FromContext(c).Errorf("error filtering user role permissions: permission not found")
response.Error(c, response.ErrNotPermitted, nil)
return
Expand Down
9 changes: 6 additions & 3 deletions backend/pkg/tools/browser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,9 +422,12 @@ func (b *browser) getScreenshot(targetURL string) (string, error) {
}

func (b *browser) callScraper(url string) ([]byte, error) {
client := &http.Client{Transport: &http.Transport{
TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
}}
client := &http.Client{
Timeout: 65 * time.Second,
Transport: &http.Transport{
TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
},
}
resp, err := client.Get(url)
if err != nil {
return nil, fmt.Errorf("failed to fetch data by scraper '%s': %w", url, err)
Expand Down