Open
Conversation
asdek
requested changes
Jul 10, 2018
asdek
left a comment
asdek
left a comment
There was a problem hiding this comment.
If exclude comment in vendor.conf file then this commit look likes good.
| github.com/pkg/errors c605e28 | ||
| github.com/rancher/go-rancher/v2 939fd85 | ||
| github.com/Sirupsen/logrus v1.0.5 | ||
| github.com/timewasted/linode/dns 37e8452 |
There was a problem hiding this comment.
I think that here it is need writing a path to github.com/timewasted/linode because this package whole used in file github.com/timewasted/linode/dns/dns.go.
Also I saw dependencies for this package:
- github.com/davecgh/go-spew/
- github.com/stretchr/testify/
These packages also need add to vendor.conf and to git commit.
|
This could be updated to https://go-acme.github.io/lego/dns/linodev4/ |
|
@displague Unfortunately I don't have an account in this provider to check compatibility. If you make pull request I can add it to my fork. |
|
@asdek This would require moving up to acme/lego 1.1.0, at least. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref janeczku#81.
@asdek I submitted this to the base repo a year ago but it never got merged. Would like to get wildcard support using Linode as the DNS provider!