This repository was archived by the owner on Nov 5, 2024. It is now read-only.
#9 fixes - execution of quasar-maven-plugin by inheritance from a pom parent fails#10
Open
cvuillecard wants to merge 1 commit intovy:masterfrom
Open
#9 fixes - execution of quasar-maven-plugin by inheritance from a pom parent fails#10cvuillecard wants to merge 1 commit intovy:masterfrom
cvuillecard wants to merge 1 commit intovy:masterfrom
Conversation
…th submodules fails - deletion of unnecessary condition when buildDirectory is null. Note : tested with multiple submodules in a maven project. Now we can declare the plugin execution in a parent pom inherited by other poms as maven sub-modules
cvuillecard
commented
Aug 27, 2020
| public void execute() throws MojoExecutionException { | ||
| getLog().info("Instrumenting Quasar classes..."); | ||
|
|
||
| if (buildDirectory == null || !buildDirectory.isDirectory()) |
Author
There was a problem hiding this comment.
buildDirectory points to ${project.build.directory} default maven build property.
Even if the 'target' directory doesn't exist, the plugin execution is not blocked. Normally we don't need to check if the current working directory is a directory because ${project.build.directory} always points to the 'target' directory of the pom's parent directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… submodules fails
Note : tested with multiple submodules in a maven project. Now we can declare the plugin execution in a parent pom inherited by other poms as maven sub-modules