docs: drop sudo from rekordbox-mode run commands#23
Merged
Conversation
rekordbox mode (the default) binds only unprivileged ports - the deck queries Pioneer's non-standard portmapper on 50111, and the README's own "Port 111 (CDJ mode only)" section says as much - but the Web UI and Directory Mode examples and the Makefile run target all started with sudo anyway, teaching every new user to run the whole app as root for nothing. The Makefile even said "no privileged ports needed" one line above the sudo. Only --mode cdj needs UDP 111; that example keeps sudo with a comment pointing at the sudo-free options (sysctl / setcap / iptables).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
rekordbox mode (the default) binds only unprivileged ports: the deck queries Pioneer's non-standard portmapper on UDP 50111, and the README's own "Port 111 (CDJ mode only)" section says exactly that. But the Web UI and Directory Mode examples and the Makefile run target all started with sudo anyway, teaching every new user to run the whole app as root for nothing. The Makefile even said "no privileged ports needed" one line above the sudo. Verified against nfs/portmap.go: the privileged port 111 bind is attempted only in CDJ mode.
sudo is dropped from the two rekordbox-mode README examples and the Makefile run target. The --mode cdj example keeps sudo, since CDJ-USB sources query the standard RPC portmapper on the privileged UDP 111, and gains a comment pointing at the sudo-free options (sysctl / setcap / iptables) already documented in the Requirements section.
Documentation and Makefile only; no code changes. The matching quick-start fix on the website shipped separately in the vynull-site repo.
Hardware testing
Checklist
go build ./...,go vet ./..., andgo test ./...passgofmt -l .is cleanGPL-3.0-or-later) (n/a, no new files)