Skip to content

make: test and check targets - #29

Merged
vynulldev merged 1 commit into
mainfrom
makefile-test
Jul 27, 2026
Merged

make: test and check targets#29
vynulldev merged 1 commit into
mainfrom
makefile-test

Conversation

@vynulldev

Copy link
Copy Markdown
Owner

What & why

Two new Makefile targets. make test runs the unit suite. make check is the full pre-release gate: build, vet, a gofmt guard, the unit tests, and then the e2e suite - one command where the release ritual previously ran five.

The gofmt step is a real guard, not just a listing: plain gofmt -l prints offending files but exits zero, so it passes silently in a command chain. The target fails the run and names the files. Verified by mutation: a deliberately misformatted file makes make check exit non-zero and print the path; removing it goes back to green.

make check was run end to end on this branch, including the e2e suite (which still needs ffmpeg and the DJ-Link UDP ports free, as documented on the e2e target).

Hardware testing

  • Tested on: N/A: Makefile only, no code change.

Checklist

  • go build ./..., go vet ./..., and go test ./... pass
  • gofmt -l . is clean
  • New source files carry an SPDX header (GPL-3.0-or-later) (n/a, no new files)
  • Tested on real hardware (deck + firmware noted above), or this change doesn't affect deck behaviour
  • I agree my contribution is licensed under the project's GPLv3

test runs the unit suite; check is the full pre-release gate - build,
vet, a failing gofmt guard, unit tests, then the e2e suite - so the
release checklist automated section is one command instead of five.
@vynulldev
vynulldev merged commit 39176a6 into main Jul 27, 2026
1 check passed
@vynulldev
vynulldev deleted the makefile-test branch July 27, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant