make: test and check targets - #29
Merged
Merged
Conversation
test runs the unit suite; check is the full pre-release gate - build, vet, a failing gofmt guard, unit tests, then the e2e suite - so the release checklist automated section is one command instead of five.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Two new Makefile targets.
make testruns the unit suite.make checkis the full pre-release gate: build, vet, a gofmt guard, the unit tests, and then the e2e suite - one command where the release ritual previously ran five.The gofmt step is a real guard, not just a listing: plain
gofmt -lprints offending files but exits zero, so it passes silently in a command chain. The target fails the run and names the files. Verified by mutation: a deliberately misformatted file makesmake checkexit non-zero and print the path; removing it goes back to green.make checkwas run end to end on this branch, including the e2e suite (which still needs ffmpeg and the DJ-Link UDP ports free, as documented on the e2e target).Hardware testing
Checklist
go build ./...,go vet ./..., andgo test ./...passgofmt -l .is cleanGPL-3.0-or-later) (n/a, no new files)