feat: added slog component and writer factory renamed#6
Open
ShyamSunder149 wants to merge 1 commit intovyrelabs:mainfrom
Open
feat: added slog component and writer factory renamed#6ShyamSunder149 wants to merge 1 commit intovyrelabs:mainfrom
ShyamSunder149 wants to merge 1 commit intovyrelabs:mainfrom
Conversation
ritvikos
requested changes
Jan 7, 2026
Member
ritvikos
left a comment
ritvikos
left a comment
There was a problem hiding this comment.
For #2, the implementation adds a restrictive logger abstraction (slogWrapper) for components. Actually it deviates from the intent of exposing slog.Logger directly at component-level (here Spooler)
For #4, the implementation adds deep nesting. It'd be cleaner to expose relevant methods directly in Writer.
Thanks for your time :)
ritvikos
force-pushed
the
main
branch
4 times, most recently
from
83dcc79 to
545f351
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I have addressed issue #2 and #4 in this PR. Kindly check and let me know whether this can be merged..
Note : Tried running lint but since there were a lot of blockers in the previous code it will not run as expected but my code doesn't have blockers. just mentioning this if this will be run in a pipeline...
Thanks