Fix typos, remove broken unused "build" system#7
Open
BenWiederhake wants to merge 2 commits intovysheng:masterfrom
Open
Fix typos, remove broken unused "build" system#7BenWiederhake wants to merge 2 commits intovysheng:masterfrom
BenWiederhake wants to merge 2 commits intovysheng:masterfrom
Conversation
Credits go to the authors of codespell.
BenWiederhake
changed the title
Contributor
Author
|
Removing the build system looks like a harsh step, but please note that it is utterly broken:
The last point makes the "build system" utterly pointless, as it is never executed anyway. In order to preventus from having out very own |
Contributor
Author
|
Is there anything from preventing this to be merged? |
Contributor
Author
|
Is there anything that prevents this from be merged? Can I do something to help? |
Open
BenWiederhake
added a commit
to majn/tgl
that referenced
this pull request
Jun 17, 2017
Originally submitted as vysheng/tl-parser#7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credits go to the authors of codespell. Note that codespell also complains about
curch, which stands for "current character", and thus probably should have been namedcur_ch