fix(win): resolve apphost license pack from SDK-chosen apphost path - #8
Merged
Merged
Conversation
The apphost-license copy target hardcoded the NuGet global cache path. That only works when the installed SDK downloads the pinned apphost pack to the cache; a machine whose SDK BUNDLES $(DotNetRuntimeVersion) serves the apphost from its own packs/ dir and never populates the cache, so the build failed with 'apphost MIT license is missing from the restored host pack'. Derive the pack directory from $(AppHostSourcePath) (the exact apphost the SDK resolved), with the old cache path as fallback. Verified: Release build clean; RuntimeLicensePackagingTests 5/5; launcher publish copies both license assets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes local Windows builds failing with 'The .NET 10.0.10 win-x64 apphost MIT license is missing from the restored host pack' on machines whose SDK bundles the pinned runtime (serves apphost from packs/ instead of the NuGet cache the target checked). Derives the pack dir from $(AppHostSourcePath); falls back to the cache path. Release build clean, RuntimeLicensePackagingTests 5/5, launcher publish copies both apphost license assets.