Fix iOS CI build failure from mixed Kotlin/Objective-C inheritance in location requester - #1
Merged
w1lderr merged 2 commits intoJul 19, 2026
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job 'build-ios'
Fix iOS CI build failure from mixed Kotlin/Objective-C inheritance in location requester
Jul 19, 2026
w1lderr
approved these changes
Jul 19, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes the iOS CI failure in :shared:compileKotlinIosSimulatorArm64 by removing the unsupported Kotlin/Native inheritance pattern that mixed Kotlin and Objective-C supertypes in the iOS LocationRequester implementation, replacing it with a composition-based wrapper while keeping the same runtime behavior.
Changes:
- Refactored
rememberLocationRequesteron iOS to return aLocationRequesterSAM wrapper that delegates to an Objective-C-only delegate class. - Updated
IosLocationRequesterto implement onlyNSObject+CLLocationManagerDelegateProtocol(no longer implements the KotlinLocationRequesterinterface). - Adjusted
request()on iOS fromoverride fun request()to a plainfun request()to match the new delegation approach.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-iosfails in GitHub Actions at:shared:compileKotlinIosSimulatorArm64due to Kotlin/Native rejecting mixed Kotlin and Objective-C supertypes in the iOS location requester implementation. This PR removes that invalid inheritance pattern while preserving existing location request behavior.Root cause
IosLocationRequesterimplemented both:NSObject,CLLocationManagerDelegateProtocol)LocationRequester)Mixing Kotlin and Objective-C supertypes is not supported.Code change
shared/src/iosMain/kotlin/org/homefix/project/features/location/LocationRequester.ios.ktIosLocationRequesternow only handles Objective-C delegate responsibilities.rememberLocationRequesterreturns aLocationRequesterwrapper that delegatesrequest()to the Objective-C-backed instance.Behavioral impact