Conversation
Contributor
There was a problem hiding this comment.
Should "the cdm" here also just be "cdm"? There are probably more cases like this.
Member
Author
There was a problem hiding this comment.
You're right, yes. I've fixed them all now.
Contributor
|
LGTM One thing for discussion though. Sentences started with lower case "cdm" looks a bit awkward. But I don't know what the recommendation is for the case... Example:
|
Member
Author
|
Another way to phrase it might be: "The [=CDM=] MUST NOT", or "The [=CDM=], cdm, MUST NOT" |
Contributor
|
Sounds good. I am fine with either suggestion. |
xhwang-chromium
approved these changes
Jun 9, 2026
Member
Author
|
Thanks, I went with the second option, so it's explicit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various algorithms in the spec say "use the cdm", but in these cases "cdm" is actally a variable that refers to an instance of the CDM. Hence "use cdm" is more appropriate.
Preview | Diff