avoid strict splitting in parseMetada to allow base64url#150
Open
Uzlopak wants to merge 1 commit into
Open
Conversation
Collaborator
|
We should make sure the feature is universally understood in all engines by adding tests to wpt before we move forward here. Would you be interested in doing so? |
Contributor
Author
|
You mean adding tests to the wpt to ensure that all the browsers implemented also base64url? |
Collaborator
|
My thinking is that I don't want the spec to enshrine something in writing that is not realistically doable because browsers were more liberal and web pages may already rely on this behavior. There is a wide variant of what a browser could do and I don't want us to assume. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should do a strict split of the algorithm-expression, but only split it on the first occurence of the dash character.
base64urls` uses the dash character too, so if we want to allow base64url we cant do strict splitting.
Preview | Diff