feat: better bytesMatch algorithm#153
Closed
Uzlopak wants to merge 1 commit into
Closed
Conversation
7 tasks
Collaborator
|
As mentioned previously, we don't concern ourselves with implementation details like performance. Implementations are free to rewire internal algorithms to improve on performance, as long as these improvements are changes that will be exposed to the web. On another note, let's discuss potential improvements in an issue before you write a pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The algorithm for matching the hashes is only performant if you have one hash provided.
Lets say for some reason you provide five sha512 hashes for the resource. Than algorithm of the spec suggests, that we should hash 5 times the bytes to get five times the same actualValue, just to compare the actualValue with the expectedValue. This is obviously imperformant and repetetive.
We just need to hash the bytes only once to get the actualValue and then only compare with the expectedValue.
(See our contributing guidelines for more details.)
Preview | Diff